8000 Make mkdir.py work under python3 versions below 3.5 by gneiss15 · Pull Request #8194 · esp8266/Arduino · GitHub
[go: up one dir, main page]
Skip to content

Make mkdir.py work under python3 versions below 3.5 #8194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 9, 2021
Merged

Make mkdir.py work under python3 versions below 3.5 #8194

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f5530b9
Create pins_arduino.h
gneiss15 Jul 1, 2021
0548a44
Update boards.txt.py
gneiss15 Jul 1, 2021
f5ecd9a
Update boards.txt
gneiss15 Jul 1, 2021
46b0a2c
done a "boards.txt.py --allgen"
gneiss15 Jul 1, 2021
82e94fa
Removed the definition of LED_BUILTIN from variants/wifi_kit_8/pins_a…
gneiss15 Jul 2, 2021
73eb2c8
Make makdir.py work unter python3 versions below 3.5
gneiss15 Jul 4, 2021
8d17aee
Merge branch 'esp8266:master' into master
gneiss15 Jul 4, 2021
90371d4
Correct Ident in mkdir.py
gneiss15 Jul 9, 2021
f8c484d
Merge branch 'master' of https://github.com/gneiss15/Arduino
gneiss15 Jul 9, 2021
fb71f53
Merge branch 'esp8266:master' into master
gneiss15 Jul 9, 2021
5f7a487
Changed to only use function call that works under python versions <3…
gneiss15 Jul 9, 2021
d07c3fe
Corrected line with spaces
gneiss15 Jul 9, 2021
2d17407
Error due to copy & paste corrected (checks had failed)
gneiss15 Jul 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make makdir.py work unter python3 versions below 3.5 
Because early versions of python3 did not have the optional arg "exist_ok" for "pathlib.Path(...).mkdir(...)" a build under this versions will abort with an error message.
This PR will modify the python script so that it works even under python 3.4 (and below).
  • Loading branch information
@gneiss15
gneiss15 committed Jul 4, 2021
commit 73eb2c81aeb8a3026a5a7084777adb94e585c8ae
35 changes: 27 additions & 8 deletions tools/mkdir.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,33 @@
import pathlib
import sys

def IsPythonVersionBelow3_5():
v = sys.version_info
if v[ 0 ] > 3 or ( v[ 0 ] == 3 and v[ 1 ] > 4 ):
return False
return True

def mkdir_3_4( p, parents_ ):
try:
pathlib.Path( p ).mkdir( parents = parents_ )
except FileExistsError:
pass

def mkdir_3_5( p, parents_ ):
pathlib.Path( p ).mkdir( parents = parents_, exist_ok = True )

def main():
parser = argparse.ArgumentParser(description='Platform-independent `mkdir`')
parser.add_argument('-p', '--parents', action='store_true', required=False, help='no error if existing, make parent directories as needed')
parser.add_argument('dir', action='store', nargs='+')
ns = parser.parse_args()
for p in ns.dir:
pathlib.Path(p).mkdir(parents=ns.parents, exist_ok=True)
return 0
parser = argparse.ArgumentParser(description='Platform-independent `mkdir`')
parser.add_argument('-p', '--parents', action='store_true', required=False, help='no error if existing, make parent directories as needed')
parser.add_argument('dir', action='store', nargs='+')
ns = parser.parse_args()
if IsPythonVersionBelow3_5():
mkdir_ = mkdir_3_4
else:
mkdir_ = mkdir_3_5
for p in ns.dir:
mkdir_( p, ns.parents )
return 0

if __name__ == '__main__':
sys.exit(main())
sys.exit(main())
0