8000 ESP8266WiFiScan::scanNetworks signature and capabilities enhancement for ESP32 compatibility by dok-net · Pull Request #8073 · esp8266/Arduino · GitHub
[go: up one dir, main page]
Skip to content

ESP8266WiFiScan::scanNetworks signature and capabilities enhancement for ESP32 compatibility #8073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dok-net wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ESP8266WiFiScan::scanNetworks signature and capabilities enhancement for ESP32 compatibility #8073

dok-net wants to merge 1 commit into from

Conversation

@dok-net
Copy link
Contributor
@dok-net dok-net commented May 23, 2021

Fixes #8053

d-a-v
d-a-v reviewed May 23, 2021
View reviewed changes
libraries/ESP8266WiFi/src/ESP8266WiFiScan.h Outdated
Copy link
Collaborator
@d-a-v d-a-v May 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change.
What about leaving the former API without the default values ?

+ int8_t scanNetworks(bool async = false, bool show_hidden = false, uint8 channel, uint8* ssid);

Copy link
Contributor Author
@dok-net dok-net May 24, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fishy, and indeed, it leads to an ambiguity error for the case of default ssid argument, because the compiler cannot distiguish the actual parameter for bool passive from uint8_t channel. Better break once, for good, in the breaking 3.0 release.

        //scanResult = WiFi.scanNetworks(/*async=*/false, /*hidden=*/true, /*passive=*/ false);
        scanResult = WiFi.scanNetworks(/*async=*/false, /*hidden=*/true, /*channel=*/0);

WiFiScan.ino: 25:54: error: call of overloaded 'scanNetworks(bool, bool, int)' is ambiguous
   25 |         scanResult = WiFi.scanNetworks(/*async=*/false, /*hidden=*/true, /*channel=*/0)
   |                                                      ^
 
ESP8266WiFi.h:36: In file included from
WiFiScan.ino:7: from
ESP8266WiFiScan.h:37: note  candidate  int8_t ESP8266WiFiScanClass  scanNetworks(bool, bool, uint8, uint8*)
   37 |         int8_t scanNetworks(bool async, bool show_hidden, uint8 channel, uint8* ssid = NULL) __attribute__((deprecated)) {
   |                ^~~~~~~~~~~~
ESP8266WiFiScan.h:40: note  candidate  int8_t ESP8266WiFiScanClass  scanNetworks(bool, bool, bool, uint32_t, uint8_t, uint8*)
   40 |         int8_t scanNetworks(bool async = false, bool show_hidden = false, bool passive = false, uint32_t max_ms_per_chan = 300, uint8_t channel = 0, uint8* ssid = NULL)
   |                ^~~~~~~~~~~~

@pabloandresm pabloandresm mentioned this pull request May 27, 2021
Closed
@dok-net dok-net force-pushed the issue_8053 branch 3 times, most recently from 4924e18 to 8000 90a05bb Compare June 8, 2021 01:43
@dok-net dok-net force-pushed the issue_8053 branch 2 times, most recently from 32a9935 to 1ba5d00 Compare October 16, 2021 10:39
@dok-net dok-net force-pushed the issue_8053 branch 2 times, most recently from 7d06151 to 25be2b8 Compare March 13, 2022 18:36
@dok-net
Fixes esp8266#8053
< 82A2 batch-deferred-content class="d-inline-block" data-url="/commits/badges">
4449800
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d-a-v d-a-v d-a-v left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

suggestion to change parameters of scanNetworks() to match the ones of ESP32

2 participants

@dok-net @d-a-v
0