8000 Extending on the new WiFi-less startup and new power saving APIs in ESP class by dok-net · Pull Request #7979 · esp8266/Arduino · GitHub
[go: up one dir, main page]
Skip to content

Extending on the new WiFi-less startup and new power saving APIs in ESP class #7979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 44 commits into
base: master
Choose a base branch
from
Open

Extending on the new WiFi-less startup and new power saving APIs in ESP class #7979

Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
810fed9
WiFi is off by default anyway.
dok-net Apr 13, 2021
a1ceef3
Set deep sleep resume and powerup RF modes to OFF.
dok-net Apr 15, 2021
9538ef9
Implement forced light sleep in Esp class
dok-net Apr 15, 2021
1ecdfc1
Add low power forced light sleep demo.
dok-net Apr 15, 2021
ef2bc95
Implement auto light sleep and auto modem sleep in Esp class
dok-net Apr 15, 2021
9891613
Add auto sleep mode demo.
dok-net Apr 15, 2021
ea94626
Refactoring MODEM forced sleep code from ESP8266WiFi to core ESP class.
dok-net Apr 16, 2021
7137d0f
Add new Esp class member functions to host test MockEsp.cpp
dok-net Apr 16, 2021
7fea539
API refactoring.
dok-net Apr 16, 2021
446aea7
Missed that there are different functions for auto and force sleep ty…
dok-net Apr 17, 2021
6a07829
DRY
dok-net Apr 17, 2021
49c2ac0
enable callback in forced light sleep example
dok-net Apr 17, 2021
e7864f1
instead of crude manual mangling and no prototypes, put the weak symb…
dok-net Apr 17, 2021
79a7ee8
Example for a forced modem sleep with timeout and callback.
dok-net Apr 18, 2021
788731e
Save 9ms for force MODEM sleep activation.
dok-net Apr 18, 2021
433cd17
Add timer_list debug dump to forced light sleep
dok-net Apr 19, 2021
24efea2
Auto light sleep is all about WiFi and requires a connection to an AP
dok-net Apr 22, 2021
83e70ee
Some comments from memory of what testing revealed. Independent verif…
dok-net Apr 24, 2021
c0326f0
Copyright notices and clarifying introductory comments in example code.
dok-net Apr 25, 2021
7c4879f
Increase delay time to let example actually show measurable times in …
dok-net Apr 25, 2021
01eb942
Remove unintended copy&paste artifact.
dok-net Apr 25, 2021
382f6fd
Reset ISR to edge triggered mode when back from sleep via timeout ins…
dok-net Apr 25, 2021
213a2e0
AttachInterrupt is not available in ISR (IRAM_ATTR), fix crash on stu…
dok-net Apr 25, 2021
56c40f3
SDK needs idle task to perform mode switching. Reset the callback poi…
dok-net Apr 25, 2021
affc7fc
Fix serial bitrate in example.
dok-net Apr 25, 2021
6015cec
Debounce the button GPIO in order to prevent crashes due to IRQ storms.
dok-net Apr 25, 2021
b6e14f6
Add documentation for the new ESP sleep modes to libraries.rst
dok-net Apr 26, 2021
ad454ea
Fix headline in documentation as well.
dok-net Apr 26, 2021
74951fd
By review comment.
dok-net Apr 26, 2021
0a70272
ESP.deepSleep[Instant] refactoring to match the setting of RF mode in…
dok-net Apr 27, 2021
df7e909
More comprehensive description of the usage of forcedLightSleep.
dok-net Apr 28, 2021
1af1380
Be more specific about ForcedLightSleepEnd.
dok-net Apr 28, 2021
a9d9cda
Describe forced light sleep initiation in more detail.
dok-net Apr 28, 2021
e8798ac
Add neverSleep and neverSleepOff to Esp class, use them in core and l…
dok-net May 17, 2021
3fc7d23
Apply suggested style fixes.
dok-net Mar 13, 2022
abd17a7
There may exist code expecting this macro definition to overwrite the…
dok-net Mar 12, 2023
a6d1f73
Merge branch 'master' into wifioff
dok-net Mar 31, 2023
5a2c2db
Merge branch 'master' into wifioff
dok-net Apr 23, 2023
2d1cb1c
Merge branch 'master' into wifioff
dok-net May 13, 2023
9847e1f
Merge branch 'master' into wifioff
dok-net Jun 17, 202 8000 3
b8a95de
Reviewer noticed that esp_suspend is part of the core for awhile now …
dok-net Jun 21, 2023
dd6ea93
Implement RAII-patterned token class for ForcedLightSleep begin()/end().
dok-net Jun 24, 2023
6252680
Code style fixes.
dok-net Jun 24, 2023
cd6d155
Merge branch 'master' into wifioff
dok-net Aug 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
SDK needs idle task to perform mode switching. Reset the callback poi… 
…nter when it is no longer needed.
  • Loading branch information
@dok-net
dok-net committed 8000 Mar 12, 2023
commit 56c40f3cb02e9a4143dac702a80a554a87a5e036
13 changes: 11 additions & 2 deletions cores/esp8266/Esp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,9 +168,9 @@ bool EspClass::forcedModemSleep(uint32_t duration_us, fpm_wakeup_cb wakeupCb)
}
// SDK turns on forced modem sleep in idle task
#ifdef HAVE_ESP_SUSPEND
esp_delay(1);
esp_delay(10);
#else
delay(1);
delay(10);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we waiting for certain condition to happen? Should it check something instead of assuming 10ms delay does something?
also not necessary ifdef

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your opinion may differ, even for a reason, but I implement to the public specification and as my comment // SDK turns on forced modem sleep in idle task explains, there shall be a delay for the idle task to take over.
Thanks for picking up the quite dated HAVE_ESP_SUSPEND, it's been so long, I don't even recall where and when it was ever defined.

#endif
return true;
}
Expand Down Expand Up @@ -269,9 +269,18 @@ void EspClass::forcedLightSleepEnd(bool cancel)
esp8266::InterruptLock lock;
timer_list = saved_timer_list;
}
saved_wakeupCb = nullptr;
wifi_fpm_close();
wifi_fpm_set_sleep_type(saved_sleep_type);
saved_sleep_type = NONE_SLEEP_T;
if (cancel) {
// let the SDK catch up in idle task
#ifdef HAVE_ESP_SUSPEND
esp_delay(10);
#else
delay(10);
#endif
}
}

void EspClass::autoModemSleep() {
Expand Down
0