8000 WString: Optimize a bit by jjsuwa · Pull Request #7553 · esp8266/Arduino · GitHub
[go: up one dir, main page]
Skip to content

WString: Optimize a bit #7553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 16, 2020
Merged

WString: Optimize a bit #7553

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f2c7565
WString: Optimize a bit
jjsuwa-sys3175 Sep 9, 2020
6e76a3a
* optimize `init()` more
jjsuwa-sys3175 Nov 15, 2020
ebe4ceb
* revise the comment
jjsuwa-sys3175 Nov 15, 2020
df10fff
Merge branch 'master' into WString_cutWaste
d-a-v Nov 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
WString: Optimize a bit 
* move bodies of dtor, `init()` and `charAt()` to .h (implicitly inlined)

* unify descriptions of the initialization into one: `init()` (literally), that is called from each ctors, `invalidate()` and `move()`

* invert the SSO state logic in order to make init state zeroed (as a result, each inlined `init()` saves 1 insn)

* detab and trim

* remove `inline` from .h

* cosmetics

* optimize the non-SSO -> SSO transition part of `changeBuffer()`

* remove duped body of `operator =(StringSumHelper &&rval)`

* remove common subexpressions from `lastIndexOf()` and `substring()`

* eliminate `strlen(buf)` after calling `sprintf(buf, ...)` that returns # of chars written

* eliminate `len()` after calling `setLen(newlen)`

* make ctor`(char c)` inlineable

* optimize `setLen()`

* replace constant-forwarding overload functions with default argument ones

* optimize `concat(char c)`

IROM size @ FSBrowser: 304916 -> 304372 (saved 544 from master)
  • Loading branch information
@jjsuwa-sys3175
jjsuwa-sys3175 committed Nov 13, 2020
commit f2c75658cef59a28011a983211f87db58f10549c
Loading
0