8000 EspSoftwareSerial 6.8.5: fixes parity for TX with odd word size modes by dok-net · Pull Request #7399 · esp8266/Arduino · GitHub
[go: up one dir, main page]
Skip to content

EspSoftwareSerial 6.8.5: fixes parity for TX with odd word size modes #7399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 24, 2020
Merged

EspSoftwareSerial 6.8.5: fixes parity for TX with odd word size modes #7399

merged 3 commits into from
Jun 24, 2020

Conversation

dok-net
Copy link
Contributor
@dok-net dok-net commented Jun 22, 2020

No description provided.

@earlephilhower
Copy link
Collaborator

@dok-net is this good for 2.7.2 or is it high risk?

@dok-net
EspSoftwareSerial 6.8.5: examples report rx errors from HW serial API…
4c3c3c7 
…, in lieu of specific parity errors, which are not made available.
@dok-net
Copy link
Contributor Author
dok-net commented Jun 23, 2020 •
edited
Loading

Having had another day, I've updated the examples to hint at parity errors from SW serial to HW serial, too.
To your question, yes, it's safe and should absolutely be in ASAP.

@dok-net dok-net changed the title EspSoftwareSerial 6.8.4: fixes parity for TX with odd word size modes EspSoftwareSerial 6.8.5: fixes parity for TX with odd word size modes Jun 23, 2020
@d-a-v
Copy link
Collaborator
d-a-v commented Jun 24, 2020

Updated to master.
@dok-net is there another planned change today ?

@d-a-v d-a-v merged commit 00fc716 into esp8266:master Jun 24, 2020
@dok-net
Copy link
Contributor Author
dok-net commented Jun 24, 2020 via email

@dok-net dok-net deleted the swserial branch June 27, 2020 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dok-net @earlephilhower @d-a-v
0