8000 Preserve phase relationship when waveform updated by earlephilhower · Pull Request #7192 · esp8266/Arduino · GitHub
[go: up one dir, main page]
Skip to content

Preserve phase relationship when waveform updated #7192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Preserve phase relationship when waveform updated #7192

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
37d9fce
Preserve phase relationship when waveform updated
earlephilhower Apr 4, 2020
6450989
Allow clock-cycle granularity for analogWrite
earlephilhower Apr 4, 2020
e75da87
Actually use the Cycles not the US call in analogWrite
earlephilhower Apr 4, 2020
6fc6b80
Use InterruptLock and not manual locking
earlephilhower Apr 5, 2020
393cc85
Fix potential race condition when Tone() updating
earlephilhower Apr 5, 2020
4b2562a
Adjust to a lockfree cycle update logic
earlephilhower Apr 6, 2020
545fa10
Move waveform vars to a struct to save IRAM
earlephilhower Apr 6, 2020
371ef22
Favor phase over duty cycle
earlephilhower Apr 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Actually use the Cycles not the US call in analogWrite
  • Loading branch information
@earlephilhower
earlephilhower committed Apr 4, 2020
commit e75da8750a6c7b3cdfd1ffd61d3b80122a9585ea
2 changes: 1 addition & 1 deletion cores/esp8266/core_esp8266_wiring_pwm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ extern void __analogWrite(uint8_t pin, int val) {
stopWaveform(pin);
digitalWrite(pin, LOW);
} else {
if (startWaveform(pin, high, low, 0)) {
if (startWaveformCycles(pin, high, low, 0)) {
analogMap |= (1 << pin);
}
}
Expand Down
0