8000 Use a python3 script to call python3 by earlephilhower · Pull Request #6960 · esp8266/Arduino · GitHub
[go: up one dir, main page]
Skip to content

Use a python3 script to call python3 #6960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 14, 2020
Merged

Use a python3 script to call python3 #6960

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a1a0d5f
Use a python3 script to call python3
earlephilhower Dec 29, 2019
ecf2f82
Explicitly remove old symlink to python3
earlephilhower Dec 29, 2019
11c3458
Merge branch 'master' into python3-for-me
d-a-v Jan 1, 2020
4ea2886
Merge branch 'master' into python3-for-me
earlephilhower Jan 6, 2020
260d259
Merge branch 'master' into python3-for-me
earlephilhower Jan 11, 2020
5eeaa80
Merge branch 'master' into python3-for-me
earlephilhower Jan 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Explicitly remove old symlink to python3 
The tar extraction for the updated python3 tarball will fail on systems
that already have a symlink in /tools/python3/python3 because the tar
extractor attempts to open the *target of the symlink* (i.e. the actual
interpreter in /usr/bin or /usr/local/bin).

Add a commented hack to destroy this symlink before expanding the
tarballs, if the file exists.  This is safe to do since it will be
overwritten by any extractions of the python3 tarball later in the
process.
  • Loading branch information
@earlephilhower
earlephilhower committed Dec 29, 2019
commit ecf2f82d3194df02402c4b30c2bd21c037760d1b
3 changes: 3 additions & 0 deletions tools/get.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,9 @@ def main():
if len(sys.argv) == 2:
if sys.argv[1] == "-q":
verbose = False
# Remove a symlink generated in 2.6.3 which causes later issues since the tarball can't properly overwrite it
if (os.path.exists('python3/python3')):
os.unlink('python3/python3')
print('Platform: {0}'.format(identify_platform()))
tools_to_download = load_tools_list('../package/package_esp8266com_index.template.json', identify_platform())
mkdir_p(dist_dir)
Expand Down
0