8000 Remove ROM routines from libc.a, save progmem by earlephilhower · Pull Request #6432 · esp8266/Arduino · GitHub
[go: up one dir, main page]
Skip to content

Remove ROM routines from libc.a, save progmem #6432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2019
Merged

Remove ROM routines from libc.a, save progmem #6432

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a3a282
Remove ROM routines from libc.a, save progmem
earlephilhower Aug 21, 2019
b9af6df
Merge branch 'master' into nomoro
earlephilhower Aug 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove ROM routines from libc.a, save progmem 
Dropped routines form libc.a which are present and usable in ROM:
`ar dv libc.a lib_a-strcmp.o lib_a-strlen.o lib_a-strncmp.o lib_a-strstr.o lib_a-memcmp.o lib_a-memcpy.o lib_a-memmove.o lib_a-memset.o lib_a-bzero.o`

Left strcpy and strncpy in libc.a because they silently support PROGMEM
accesses as required by GCC optimizations.

Saves ~628 bytes in AdvancedWebServer example, from IROM (not IRAM).

Also allows mem* and str* routines to be safely called from inside an
ISR.  Prior to this PR, these routines were stored in flash and not
IRAM, so they were technically illegal to call while in an ISR.

Fixes #6430
  • Loading branch information
@earlephilhower
earlephilhower committed Aug 21, 2019
commit 0a3a282f5158869e29cf2760c79c153cb3156d8d
Binary file modified tools/sdk/libc/xtensa-lx106-elf/lib/libc.a
View file
Open in desktop
Binary file not shown.
0