8000 Make waveform generator a NMI to run always, increase accuracy by earlephilhower · Pull Request #5578 · esp8266/Arduino · GitHub
[go: up one dir, main page]
Skip to content

Make waveform generator a NMI to run always, increase accuracy #5578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 11, 2019
Merged

Make waveform generator a NMI to run always, increase accuracy #5578

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c43b321
Make waveform generator a NMI to run always
earlephilhower Jan 3, 2019
99af25c
Move to a lockless waveform generator
Jan 4, 2019
78fba4c
Optimize IRAM and CPU usage in IRQ
earlephilhower Jan 5, 2019
923f2f4
Fix boolean/bitmask typo in starting waveform
earlephilhower Jan 5, 2019
409fc91
Add'l testing and tweaking at 160 and 80mhz
earlephilhower Jan 6, 2019
1d2c939
Avoid WDT errors, optimize pin scans
earlephilhower Jan 7, 2019
5c866c5
Merge branch 'master' into wvftonmi
earlephilhower Jan 7, 2019
ae4f704
Merge branch 'master' into wvftonmi
earlephilhower Jan 7, 2019
91bec0b
Clean up format/comment, remove delay() in stop
earlephilhower Jan 8, 2019
96cb073
Merge branch 'master' into wvftonmi
earlephilhower Jan 8, 2019
36a5487
Merge branch 'master' into wvftonmi
earlephilhower Jan 9, 2019
38658f5
Merge branch 'master' into wvftonmi
devyte Jan 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix boolean/bitmask typo in starting waveform
  • Loading branch information
@earlephilhower
earlephilhower committed Jan 5, 2019
commit 923f2f41033ebecfdfc64a7d4caa4a1f6d4b24d4
4 changes: 2 additions & 2 deletions cores/esp8266/core_esp8266_waveform.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ int startWaveform(uint8_t pin, uint32_t timeHighUS, uint32_t timeLowUS, uint32_t
}

uint32_t mask = 1<<pin;
if (!waveformEnabled && mask) {
if (!(waveformEnabled & mask)) {
// Actually set the pin high or low in the IRQ service to guarantee times
wave->nextServiceCycle = GetCycleCount() + MicrosecondsToCycles(1);
waveformToEnable |= mask;
Expand All @@ -143,7 +143,7 @@ int startWaveform(uint8_t pin, uint32_t timeHighUS, uint32_t timeLowUS, uint32_t
}
timer1_write(MicrosecondsToCycles(1)); // Cause an interrupt post-haste
while (waveformToEnable) {
delay(1); // Wait for waveform to update
delay(0); // Wait for waveform to update
}
}

Expand Down
0