10000 Move BearSSLHelpers into BearSSL namespace by earlephilhower · Pull Request #5315 · esp8266/Arduino · GitHub
[go: up one dir, main page]
Skip to content

Move BearSSLHelpers into BearSSL namespace #5315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 7, 2018
Merged

Move BearSSLHelpers into BearSSL namespace #5315

merged 4 commits into from
Nov 7, 2018

Conversation

earlephilhower
Copy link
Collaborator

BearSSLX509List, BearSSLSession, BearSSLPublicKey, and BearSSLPrivateKey
were all in the global namespace and not in the BearSSL:: one, due to an
oversight when they were originally created. Move them to the proper
namespace with the following mapping:
BearSSLX509List => BearSSL::X509List
BearSSLSession => BearSSL::Session
BearSSLPublicKey => BearSSL::PublicKey
BearSSLPrivateKey => BearSSL::PrivateKey

Move BearSSLHelpers into BearSSL namespace
3fc8408 
BearSSLX509List, BearSSLSession, BearSSLPublicKey, and BearSSLPrivateKey
were all in the global namespace and not in the BearSSL:: one, due to an
oversight when they were originally created.  Move them to the proper
namespace with the following mapping:
    BearSSLX509List => BearSSL::X509List
    BearSSLSession => BearSSL::Session
    BearSSLPublicKey => BearSSL::PublicKey
    BearSSLPrivateKey => BearSSL::PrivateKey
@earlephilhower earlephilhower added this to the 2.5.0 milestone Nov 6, 2018
@earlephilhower earlephilhower requested a review from devyte November 6, 2018 22:04
@earlephilhower earlephilhower merged commit 233d3e3 into esp8266:master Nov 7, 2018
@earlephilhower earlephilhower deleted the helperstonamespace branch November 7, 2018 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devyte devyte devyte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@earlephilhower @devyte
0