Add warning when no authenticator, drop verify() #5205

earlephilhower · 2018-10-03T21:27:47Z

Print a warning when in debug mode when a BearSSL connection tries to
connect without having any defined authentication methods, since it will
fail.

Completely remove the empty axTLS compatibilty method
"::verify(char *fp, char *name)" because it can't be done w/BearSSL w/o
code changes, and always failed. Better to have a compile failure when
we know at compile time the app won't do what is expected.

Completes the changes started by @d-a-v in PR #4833

@d-a-v

Print a warning when in debug mode when a BearSSL connection tries to connect without having any defined authentication methods, since it will fail. Completely remove the empty axTLS compatibilty method "::verify(char *fp, char *name)" because it can't be done w/BearSSL w/o code changes, and always failed. Better to have a compile failure when we know at compile time the app won't do what is expected. Completes the changes started by @d-a-v in PR esp8266#4833

earlephilhower mentioned this pull request Oct 3, 2018

BearSSL client: warn user on misconfiguration, allow flash string for fingerprint #4833

Closed

earlephilhower self-assigned this Oct 3, 2018

d-a-v approved these changes Oct 3, 2018

View reviewed changes

Merge branch 'master' into warnnoauth

52a958b

earlephilhower merged commit 14808c9 into esp8266:master Oct 4, 2018

earlephilhower deleted the warnnoauth branch November 18, 2020 00:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add warning when no authenticator, drop verify() #5205

Add warning when no authenticator, drop verify() #5205

Uh oh!

Uh oh!

Uh oh!