Bugfix and accepting put data #4151
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devyte
approved these changes
Jan 14, 2018
reloxx13
added a commit
to reloxx13/Arduino
that referenced
this pull request
Jan 24, 2018
The PR for esp8266#4235 This esp8266#4151 is the same issue, but with a diffrent solution.
This was referenced Oct 10, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESP8266WebServer.cpp does not compile if Debug-Level HTTP_SERVER is enabled. (DEBUG_OUTPUT not declared in this scope) This commit fixes the issue.
The other file contains a feature request: I have one application (actualy a Amazon Echo 1st Gen) that sends a put-request with contentype "application/x-www-form-urlencoded" set in the headers but sends out json encoded data. _parseArguments fails to parse the arguments (which is correct) but completly discards the data. This change checks if the parser picked something up and if it didn't, it just adds it as plain data to the arguments.