WebServer.serveStatic: index.html.gz as default doesn't work (while index.html does) #6984

JasperHorn · 2020-01-04T15:38:30Z

Apologies for forgoing the prescribed format. I noticed this problem while reading the code and though I did test it, that does make things like hardware information irrelevant. I decided to cut out that noise instead. (The issue that this is related to also didn't follow that format...)

Using index.html instead of index.htm for the "folder" is supported since 9f2cfb8

At that time, the lookup order became:

index.htm
index.html
index.html.gz

As #6792 pointed out, this broke support for index.htm.gz and this was changed in 6768116 . The lookup order now is:

index.htm
index.html
index.htm.gz

However, this has removed support for using index.html.gz completely. I think the lookup order should include four items:

index.htm
index.html
index.htm.gz
index.html.gz

(Perhaps with 2 & 3 reversed.)

The text was updated successfully, but these errors were encountered:

devyte · 2020-01-27T16:57:12Z

2 and 3 should be reversed.
Can you please make a PR with your suggestion?

earlephilhower · 2020-02-09T16:52:01Z

2 and 3 should be reversed

I would humbly suggest that anyone evil enough to have both a index.htm.gz and a index.html and expect for a sane solution gets the randomness they deserve.

Fixes esp8266#6984 When a directory index is requested with an explicit index.html, follow the original webserver order and check for: index.htm, index.htm.gz, index.html, index.html.gz, in order. Fixes the regressions introduced in 9f2cfb8 and 6768116

Fixes #6984 When a directory index is requested with an explicit index.html, follow the original webserver order and check for: index.htm, index.htm.gz, index.html, index.html.gz, in order. Fixes the regressions introduced in 9f2cfb8 and 6768116

JasperHorn · 2020-02-09T23:34:35Z

Thanks for picking this up during my radio silence. I was still planning to get back to this, but had since moved on to non-esp projects and didn't get around to this.

Now there's just my other (accepted) pull request which is in need of a follow-up...

earlephilhower mentioned this issue Feb 9, 2020

Fix serach order for index.htm(l)(.gz) files #7069

Merged

devyte closed this as completed in #7069 Feb 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

WebServer.serveStatic: index.html.gz as default doesn't work (while index.html does) #6984

WebServer.serveStatic: index.html.gz as default doesn't work (while index.html does) #6984

Uh oh!

Uh oh!

Uh oh!