fix(examples): fix LVGL_PORT_ROTATION_DEGREE issue
#89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddb9425 to
77167a2
Compare
|
Hi @lboue, Could you please help me test this PR to see if the related bugs are resolved? Thank you very much. |
3c7e29a to
e9d59f3
Compare
|
@Lzw655 |
|
I am having an issue with GPIO expander and Waveshare_ESP32_S3_Touch_LCD_4_3 board because I2C bus is already initialized: Build error ESP32_S3_Touch_LCD_4.3.h Config Serial log |
|
@lboue Sorry, this issue is indeed a bug in the file ////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
///////////////////////////// Please update the following macros to configure the IO expander //////////////////////////
////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
/* Set to 0 if not using IO Expander */
#define ESP_PANEL_USE_EXPANDER (1) // 0/1
#if ESP_PANEL_US
8000
E_EXPANDER
/**
* IO expander name.
*/
#define ESP_PANEL_EXPANDER_NAME CH422G
/* IO expander Settings */
/**
* If set to 1, the driver will skip to initialize the corresponding host. Users need to initialize the host in advance.
* It is useful if other devices use the same host. Please ensure that the host is initialized only once.
*/
#define ESP_PANEL_EXPANDER_SKIP_INIT_HOST (1) // 0/1
/* IO expander parameters */
#define ESP_PANEL_EXPANDER_HOST_ID (0) // Typically set to 0
#define ESP_PANEL_EXPANDER_I2C_ADDRESS (0x24)
#if !ESP_PANEL_EXPANDER_SKIP_INIT_HOST
#define ESP_PANEL_EXPANDER_I2C_CLK_HZ (400 * 1000)
// Typically set to 400K
#define ESP_PANEL_EXPANDER_I2C_SCL_PULLUP (0) // 0/1
#define ESP_PANEL_EXPANDER_I2C_SDA_PULLUP (0) // 0/1
#define ESP_PANEL_EXPANDER_I2C_IO_SCL (18)
#define ESP_PANEL_EXPANDER_I2C_IO_SDA (8)
#endif
#endif /* ESP_PANEL_USE_EXPANDER */The issue has been fixed in the new commit. Thank you for testing it! |
… working properly
84c0e7d to
9293114
Compare
@Lzw655 I have just redone a test against the latest branch commit and it now works with Waveshare_ESP32_S3_Touch_LCD_4_. I think we can validate this PR. This will make testing easier before releasing the new version. I noticed a warning but GT911TC works well: Serial log GT911 config |
|
@lboue Thank you for your thorough testing. Since the GT911 can set the I2C address using the RST and INT pins, this warning appears if these two pins are not set in the driver. There's no need to worry about it. I'll go ahead and merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LVGL_PORT_ROTATION_DEGREEissue #76LCD Venbdortypo #92