8000 fix: add missing rule option types by ntnyq · Pull Request #20127 · eslint/eslint · GitHub
[go: up one dir, main page]
Skip to content

fix: add missing rule option types #20127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2025
Merged

fix: add missing rule option types #20127

merged 1 commit into from
Sep 16, 2025
+5 −0

Conversation

ntnyq
Copy link
Contributor
@ntnyq ntnyq commented Sep 16, 2025 •
edited
Loading

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

This PR adds the missing rule option types in rules.d.ts.

Is there anything you'd like reviewers to focus on?

Related links:

Besides, does ESLint accept rule option changes for deprecated rules?

Cause there are many missing rule option types for them.

@Copilot Copilot AI review requested due to automatic review settings September 16, 2025 04:17
@ntnyq ntnyq requested a review from a team as a code owner September 16, 2025 04:17
@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label Sep 16, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Sep 16, 2025
Copilot
Copilot AI reviewed Sep 16, 2025
View reviewed changes
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@netlify Netlify
Copy link
netlify bot commented Sep 16, 2025 •
edited
Loading

✅ Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 5c74ee1
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/68c8e4dcf4d13f000879e0b7

@mdjermanovic mdjermanovic moved this from Needs Triage to Triaging in Triage Sep 16, 2025
mdjermanovic
mdjermanovic approved these changes Sep 16, 2025
View reviewed changes
Copy link
Member
@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic
Copy link
Member

Besides, does ESLint accept rule option changes for deprecated rules?

We are not making any changes to deprecated rules, and that includes types.

@mdjermanovic mdjermanovic merged commit 75b74d8 into eslint:main Sep 16, 2025
30 checks passed
@github-project-automation github-project-automation bot moved this from Triaging to Complete in Triage Sep 16, 2025
@mdjermanovic mdjermanovic added the types Related to TypeScript types label Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees
No one assigned
Labels
bug ESLint is working incorrectly contributor pool types Related to TypeScript types
Projects
Triage
Status: Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntnyq @mdjermanovic
0