8000 [EasySsm][EasyTest] Make console commands lazy by ERuban · Pull Request #381 · eonx-com/easy-monorepo · GitHub
[go: up one dir, main page]
Skip to content

[EasySsm][EasyTest] Make console commands lazy #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2020
Merged

[EasySsm][EasyTest] Make console commands lazy #381

merged 1 commit into from
Oct 6, 2020

Conversation

ERuban
Copy link
Contributor
@ERuban ERuban commented Oct 2, 2020
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -

This PR is about of a little optimisation to avoid initialisation of all command services on each executing bin/console command.
Since Symfony 3.4 console commands can be lazy thanks to a static name property.
This change does not break BC because the BC layer is already in the base command's constructor.

@ERuban
hotfix/lazy-console-commands
092f707 
- Make console commands lazy.
@ERuban ERuban requested a review from roman-eonx October 2, 2020 18:04
@sonarqubecloud
Copy link
sonarqubecloud bot commented Oct 2, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
44.4% 44.4% Duplication

@roman-eonx roman-eonx requested a review from natepage October 5, 2020 05:59
@natepage natepage merged commit db073eb into master Oct 6, 2020
@natepage natepage deleted the hotfix/lazy-console-commands branch October 6, 2020 00:36
@roman-eonx roman-eonx changed the title [EasySsm][EasyTest] Make console commands lazy. [EasySsm][EasyTest] Make console commands lazy Oct 6, 2020
DKeeper pushed a commit that referenced this pull request Mar 8, 2021
@ERuban
[EasySsm][EasyTest] Make console commands lazy. (#381)
9b0901d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natepage natepage natepage approved these changes

@roman-eonx roman-eonx roman-eonx approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ERuban @natepage @roman-eonx
0