8000 minor #36355 [OptionsResolver] remove assertions that can never be re… · enflow/symfony@434a03a · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Feb 10, 2022. It is now read-only.

Commit 434a03a

Browse files
nicolas-grekasnicolas-grekas
committed
minor symfony#36355 [OptionsResolver] remove assertions that can never be reached (xabbuh)
This PR was merged into the 3.4 branch. Discussion ---------- [OptionsResolver] remove assertions that can never be reached | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Commits ------- 112b5de remove assertions that can never be reached
2 parents efc93a7 + 112b5de commit 434a03a

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

‎src/Symfony/Component/OptionsResolver/Tests/Debug/OptionsResolverIntrospectorTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public function testGetDefaultThrowsOnNoConfiguredValue()
4444
$resolver->setDefined($option = 'foo');
4545

4646
$debug = new OptionsResolverIntrospector($resolver);
47-
$this->assertSame('bar', $debug->getDefault($option));
47+
$debug->getDefault($option);
4848
}
4949

5050
public function testGetDefaultThrowsOnNotDefinedOption()
@@ -54,7 +54,7 @@ public function testGetDefaultThrowsOnNotDefinedOption()
5454
$resolver = new OptionsResolver();
5555

5656
$debug = new OptionsResolverIntrospector($resolver);
57-
$this->assertSame('bar', $debug->getDefault('foo'));
57+
$debug->getDefault('foo');
5858
}
5959

6060
public function testGetLazyClosures()
@@ -75,7 +75,7 @@ public function testGetLazyClosuresThrowsOnNoConfiguredValue()
7575 $resolver->setDefined($option = 'foo');
7676

7777
$debug = new OptionsResolverIntrospector($resolver);
78-
$this->assertSame('bar', $debug->getLazyClosures($option));
78+
$debug->getLazyClosures($option);
7979
}
8080

8181
public function testGetLazyClosuresThrowsOnNotDefinedOption()
@@ -85,7 +85,7 @@ public function testGetLazyClosuresThrowsOnNotDefinedOption()
8585
$resolver = new OptionsResolver();
8686

8787
$debug = new OptionsResolverIntrospector($resolver);
88-
$this->assertSame('bar', $debug->getLazyClosures('foo'));
88+
$debug->getLazyClosures('foo');
8989
}
9090

9191
public function testGetAllowedTypes()

0 commit comments

Comments
 (0)
0