minor symfony#36311 [PropertyAccess] Improve message of unitialized property in php 7.4 (lmasforne)

fabpot · fabpot · commit efc93a7e17d4 · 2020-04-06T10:09:12.000+02:00
This PR was squashed before being merged into the 3.4 branch. Discussion ---------- [PropertyAccess] Improve message of unitialized property in php 7.4 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Fix symfony#36277 | License | MIT Improve message of unitialized property in php 7.4 ; Before You should either initialize it or make it nullable using "?string" instead. After You should either initialize it or make it nullable using "?string $var = null" instead. Commits ------- 3c8bf2d [PropertyAccess] Improve message of unitialized property in php 7.4
diff --git a/src/Symfony/Component/PropertyAccess/PropertyAccessor.php b/src/Symfony/Component/PropertyAccess/PropertyAccessor.php
@@ -505,7 +505,7 @@ private function readProperty($zval, $property)
             if (\PHP_VERSION_ID >= 70400 && preg_match('/^Typed property ([\w\\\]+)::\$(\w+) must not be accessed before initialization$/', $e->getMessage(), $matches)) {
                 $r = new \ReflectionProperty($matches[1], $matches[2]);
 
-                throw new AccessException(sprintf('The property "%s::$%s" is not readable because it is typed "%3$s". You should either initialize it or make it nullable using "?%3$s" instead.', $r->getDeclaringClass()->getName(), $r->getName(), $r->getType()->getName()), 0, $e);
+                throw new AccessException(sprintf('The property "%s::$%s" is not readable because it is typed "%2$s". You should initialize it or declare a default value instead.', $r->getDeclaringClass()->getName(), $r->getType()->getName()), 0, $e);
             }
 
             throw $e;
diff --git a/src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php b/src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php
@@ -126,7 +126,7 @@ public function testGetValueThrowsExceptionIfIndexNotFoundAndIndexExceptionsEnab
     public function testGetValueThrowsExceptionIfUninitializedProperty()
     {
         $this->expectException('Symfony\Component\PropertyAccess\Exception\AccessException');
-        $this->expectExceptionMessage('The property "Symfony\Component\PropertyAccess\Tests\Fixtures\UninitializedProperty::$uninitialized" is not readable because it is typed "string". You should either initialize it or make it nullable using "?string" instead.');
+        $this->expectExceptionMessage('The property "Symfony\Component\PropertyAccess\Tests\Fixtures\UninitializedProperty::$uninitialized" is not readable because it is typed "string". You should initialize it or declare a default value instead.');
 
         $this->propertyAccessor->getValue(new UninitializedProperty(), 'uninitialized');
     }

Original file line number	Diff line number	Diff line change
`@@ -505,7 +505,7 @@ private function readProperty($zval, $property)`
`505`	`505`	`if (\PHP_VERSION_ID >= 70400 && preg_match('/^Typed property ([\w\\\]+)::\$(\w+) must not be accessed before initialization$/', $e->getMessage(), $matches)) {`
`506`	`506`	`$r = new \ReflectionProperty($matches[1], $matches[2]);`
`507`	`507`
`508`		`- throw new AccessException(sprintf('The property "%s::$%s" is not readable because it is typed "%3$s". You should either initialize it or make it nullable using "?%3$s" instead.', $r->getDeclaringClass()->getName(), $r->getName(), $r->getType()->getName()), 0, $e);`
	`508`	`+ throw new AccessException(sprintf('The property "%s::$%s" is not readable because it is typed "%2$s". You should initialize it or declare a default value instead.', $r->getDeclaringClass()->getName(), $r->getType()->getName()), 0, $e);`
`509`	`509`	`}`
`510`	`510`
`511`	`511`	`throw $e;`
Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,7 @@ public function testGetValueThrowsExceptionIfIndexNotFoundAndIndexExceptionsEnab`
`126`	`126`	`public function testGetValueThrowsExceptionIfUninitializedProperty()`
`127`	`127`	`{`
`128`	`128`	`$this->expectException('Symfony\Component\PropertyAccess\Exception\AccessException');`
`129`		- $this->expectExceptionMessage('The property "Symfony\Component\PropertyAccess\Tests\Fixtures\UninitializedProperty::$uninitialized" is not readable because it is typed "string". You should either initialize it or make it nullable using "?string" instead.');
	`129`	`+ $this->expectExceptionMessage('The property "Symfony\Component\PropertyAccess\Tests\Fixtures\UninitializedProperty::$uninitialized" is not readable because it is typed "string". You should initialize it or declare a default value instead.');`
`130`	`130`
`131`	`131`	`$this->propertyAccessor->getValue(new UninitializedProperty(), 'uninitialized');`
`132`	`132`	`}`