Pluralize list operations ending in "y" appropriately for OpenAPI schema generation #7447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems a reasonable suggestion. Thanks. |
|
Neglected "day" -> "daies," probably needs more work or just rely on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Words ending with "y" should have an "ies" plural form in English. I was debating including some sort of
pluralizemethod, but it seems like we assume (for now) that English is being used, based on the default behavior with adding "s". I see that one could setoperation_id_base='Entrie', but it seems so commonplace to want to substitute the final "y" that I would argue it should be done automatically.