8000 Remove duplicate test in `tests/test_utils.py` by hramezani · Pull Request #6736 · encode/django-rest-framework · GitHub
[go: up one dir, main page]
Skip to content

Remove duplicate test in tests/test_utils.py #6736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2019
Merged

Remove duplicate test in tests/test_utils.py #6736

merged 1 commit into from
Jun 7, 2019

Conversation

hramezani
Copy link
Contributor

Description

Remove duplicate test. this test already is in

django-rest-framework/tests/test_utils.py

Line 206 in 9ac9c1b

def test_valid_unicode_preserved(self):

Also, this test is for replace_query_param but by mistake placed on UrlsRemoveQueryParamTests.

@rpkilby
Copy link
Member
rpkilby commented Jun 6, 2019

Should the test be updated to call remove_query_param instead of replace_query_param?

@tomchristie
Copy link
Member

Looks valid to me. Thanks!

@tomchristie tomchristie merged commit 60bcc93 into encode:master Jun 7, 2019
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
@hramezani
Remove duplicate test in tests/test_utils.py (encode#6736)
c72ae62
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022
@hramezani @sigvef
Remove duplicate test in tests/test_utils.py (encode#6736)
9370002
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hramezani @rpkilby @tomchristie
0