8000 Remove unnecessary bytes() calls by jdufresne · Pull Request #6626 · encode/django-rest-framework · GitHub
[go: up one dir, main page]
Skip to content

Remove unnecessary bytes() calls #6626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2019
Merged

Remove unnecessary bytes() calls #6626

merged 1 commit into from
May 30, 2019

Conversation

jdufresne
Copy link
Contributor
  • Use a simpler literal for an empty bytes object.
  • .encode() always returns a new immutable bytes object, no need to coerce it a 2nd time.

@carltongibson
Copy link
Collaborator

Can you rebase this Jon? There's a lingering six reference in there. 🙂

@jdufresne
Remove unnecessary bytes() calls
66bf9af 
- Use a simpler literal for an empty bytes object.
- .encode() always returns a new immutable bytes object, no need to
  coerce it a 2nd time.
@jdufresne
Copy link
Contributor Author

Rebased 🙂

@rpkilby rpkilby merged commit b37aa28 into encode:master May 30, 2019
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
@jdufresne
Remove unnecessary bytes() calls (encode#6626)
b1bd539
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022
@jdufresne @sigvef
Remove unnecessary bytes() calls (encode#6626)
a52239c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carltongibson carltongibson carltongibson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdufresne @carltongibson @rpkilby
0