8000 Merge multiple isinstance() calls to one by jdufresne · Pull Request #6481 · encode/django-rest-framework · GitHub
[go: up one dir, main page]
Skip to content

Merge multiple isinstance() calls to one #6481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2019
Merged

Merge multiple isinstance() calls to one #6481

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rest_framework/fields.py
View file
Open in desktop
40C4
Original file line number Diff line number Diff line change
Expand Up @@ -1660,7 +1660,7 @@ def to_internal_value(self, data):
"""
if html.is_html_input(data):
data = html.parse_html_list(data, default=[])
if isinstance(data, type('')) or isinstance(data, Mapping) or not hasattr(data, '__iter__'):
if isinstance(data, (type(''), Mapping)) or not hasattr(data, '__iter__'):
self.fail('not_a_list', input_type=type(data).__name__)
if not self.allow_empty and len(data) == 0:
self.fail('empty')
Expand Down
0