8000 fix(emqx_ee_connector): log reason for failure when starting influxdb connector by olcai · Pull Request #9881 · emqx/emqx · GitHub
[go: up one dir, main page]
Skip to content

fix(emqx_ee_connector): log reason for failure when starting influxdb connector #9881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 28, 2023
Merged

fix(emqx_ee_connector): log reason for failure when starting influxdb connector #9881

merged 6 commits into from
Feb 28, 2023

Conversation

@olcai
Copy link
Contributor
@olcai olcai commented Feb 1, 2023 •
edited
Loading

The influxdb-client-erl lib doesn't return a reason for why it is not alive. This commit is built upon a PR, emqx/influxdb-client-erl#44, that allows the caller to request this extra information. We use it to log the error reason so that it is easier to debug connection issues to InfluxDB.

Fixes EMQX-8785.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/<version>/(feat|fix)-<PR-id>.en.md and .zh.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

olcai
olcai commented Feb 1, 2023
View reviewed changes
@olcai olcai force-pushed the log-influxdb-is-alive-reason branch 2 times, most recently from 22232f7 to d03786b Compare February 23, 2023 12:20
@olcai olcai changed the base branch from release-50 to master February 23, 2023 12:21
olcai
olcai commented Feb 23, 2023
View reviewed changes
@olcai olcai marked this pull request as ready for review February 23, 2023 12:53
@olcai olcai requested a review from a team as a code owner February 23, 2023 12:53
@olcai olcai force-pushed the log-influxdb-is-alive-reason branch from e173d84 to 3ac4ed7 Compare February 24, 2023 08:03
zmstone
zmstone reviewed Feb 24, 2023
View reviewed changes
zmstone
zmstone reviewed Feb 24, 2023
View reviewed changes
@olcai olcai force-pushed the log-influxdb-is-alive-reason branch from 3ac4ed7 to 44c0aae Compare February 24, 2023 10:33
@id id merged commit 6ce5029 into emqx:master Feb 28, 2023
@olcai olcai deleted the log-influxdb-is-alive-reason branch March 1, 2023 05:21
@sstrigler sstrigler mentioned this pull request Mar 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmstone zmstone zmstone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@olcai @zmstone @id
0