8000 feat(mongo): expose buffer worker opts to the bridge frontend (5.0) by thalesmg · Pull Request #9742 · emqx/emqx · GitHub
[go: up one dir, main page]
Skip to content

feat(mongo): expose buffer worker opts to the bridge frontend (5.0) #9742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2023
Merged

feat(mongo): expose buffer worker opts to the bridge frontend (5.0) #9742

merged 1 commit into from
Jan 13, 2023

Conversation

@thalesmg
Copy link
Contributor
@thalesmg thalesmg commented Jan 12, 2023

No description provided.

@thalesmg thalesmg force-pushed the expose-resource-opts-mongo-v50 branch 2 times, most recently from 769de36 to ed9b647 Compare January 12, 2023 16:29
zmstone
zmstone reviewed Jan 12, 2023
View reviewed changes
lib-ee/emqx_ee_bridge/src/emqx_ee_bridge_mongodb.erl Outdated
Copy link
Member
@zmstone zmstone Jan 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just hoconsc:mk/2 a new one instead of manipulating an opaque term.

Copy link
Contributor Author
@thalesmg thalesmg Jan 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll do that.

But it feels dangerous that it's quite easy for the "upstream" type to change and then this new version will get out of date. 🙊

@thalesmg thalesmg force-pushed the expose-resource-opts-mongo-v50 branch from ed9b647 to e776dd1 Compare January 12, 2023 16:38
@thalesmg thalesmg force-pushed the expose-resource-opts-mongo-v50 branch from e776dd1 to ed2be4d Compare January 12, 2023 18:23
@thalesmg thalesmg marked this pull request as ready for review January 12, 2023 19:37
@thalesmg thalesmg requested a review from a team as a code owner January 12, 2023 19:37
@thalesmg thalesmg merged commit f25bd28 into emqx:master Jan 13, 2023
@thalesmg thalesmg deleted the expose-resource-opts-mongo-v50 branch January 13, 2023 13:23
@thalesmg thalesmg mentioned this pull request Jun 29, 2023
Merged
3 tasks
thalesmg added a commit to thalesmg/emqx that referenced this pull request Jun 30, 2023
@thalesmg
fix(mongodb): hide topology.pool_size and fix it at 1
3c8f591 
Fixes https://emqx.atlassian.net/browse/EMQX-10408

From an old conversation with @kjellwinblad:

> There are 3 pool_sizes
> - The buffer workers pool size, just exposed here: emqx#9742
> - The topology.pool_size, which controls the pool size for the poolboy_pool in Kjell's
  diagram (on mongodb's side).
> - The pool_size from emqx_connector_mongo:mongo_fields that controls the ecpool pool
  size (on EMQX's side).
> So we actually want to set topology.pool_size = 1 and hide it from users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmstone zmstone zmstone left review comments

@ieQu1 ieQu1 ieQu1 approved these changes

+1 more reviewer

@k32 k32 k32 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thalesmg @zmstone @k32 @ieQu1
0