8000 fix(rule_engine): rule id in path urlencoded by JimMoen · Pull Request #9190 · emqx/emqx · GitHub
[go: up one dir, main page]
Skip to content

fix(rule_engine): rule id in path urlencoded #9190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 28, 2022
Merged

fix(rule_engine): rule id in path urlencoded #9190

merged 3 commits into from
Oct 28, 2022

Conversation

@JimMoen
Copy link
Member
@JimMoen JimMoen commented Oct 20, 2022 •
edited
Loading

rule_id and resource_id could be any unicode character now.

Note:

EMQX Dashboard limited rule_id and resource_id with re ^([0-9a-zA-Z:_])*$.
But user can still create rules/resources with any unicode character as id by manually request HTTP API.

@JimMoen JimMoen requested a review from zmstone as a code owner October 20, 2022 09:57
terry-xiaoyu
terry-xiaoyu reviewed Oct 20, 2022
View reviewed changes
@JimMoen JimMoen force-pushed the rule-engine-api-id branch from 8ab37fc to 8bdb548 Compare October 20, 2022 10:07
terry-xiaoyu
terry-xiaoyu previously approved these changes Oct 20, 2022
View reviewed changes
@terry-xiaoyu
Copy link
Member
terry-xiaoyu commented Oct 20, 2022

The change log is need to be updated.

@JimMoen JimMoen force-pushed the rule-engine-api-id branch 2 times, most recently from bdb0c4e to a0b1664 Compare October 20, 2022 12:06
lafirest
lafirest reviewed Oct 20, 2022
View reviewed changes
terry-xiaoyu
terry-xiaoyu previously approved these changes Oct 21, 2022
View reviewed changes
xiangfangyang-tech
xiangfangyang-tech previously approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor
@xiangfangyang-tech xiangfangyang-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested good

@JimMoen JimMoen force-pushed the rule-engine-api-id branch from a0b1664 to 3388037 Compare October 25, 2022 02:00
@JimMoen
Copy link
Member Author
JimMoen commented Oct 25, 2022

conflicts resolved.

terry-xiaoyu
terry-xiaoyu previously approved these changes Oct 25, 2022
View reviewed changes
@JimMoen JimMoen force-pushed the rule-engine-api-id branch from 3388037 to caddec2 Compare October 26, 2022 16:39
zmstone
zmstone reviewed Oct 26, 2022
View reviewed changes
@JimMoen JimMoen force-pushed the rule-engine-api-id branch from caddec2 to a9e8351 Compare October 27, 2022 09:32
zmstone
zmstone reviewed Oct 28, 2022
View reviewed changes
zmstone
zmstone reviewed Oct 28, 2022
View reviewed changes
@JimMoen JimMoen merged commit 139aabd into emqx:main-v4.3 Oct 28, 2022
@JimMoen JimMoen deleted the rule-engine-api-id branch October 28, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lafirest lafirest lafirest left review comments

@zmstone zmstone zmstone approved these changes

@terry-xiaoyu terry-xiaoyu terry-xiaoyu left review comments

+1 more reviewer

@xiangfangyang-tech xiangfangyang-tech xiangfangyang-tech left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JimMoen @terry-xiaoyu @zmstone @lafirest @xiangfangyang-tech
0