E534 Cannot reset metrics for fallback actions by terry-xiaoyu · Pull Request #9125 · emqx/emqx · GitHub
[go: up one dir, main page]
Skip to content

Cannot reset metrics for fallback actions #9125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 10, 2022
Merged

Cannot reset metrics for fallback actions #9125

merged 2 commits into from
Oct 10, 2022

Conversation

@terry-xiaoyu
Copy link
Member
@terry-xiaoyu terry-xiaoyu commented Oct 10, 2022 •
edited
Loading

Before this change, the HTTP API /rules/:bin:id/reset_metrics can only reset metrics of the top-level actions of a rule, but metrics of the fallback actions are not reset.

@terry-xiaoyu terry-xiaoyu requested a review from zmstone October 10, 2022 09:23
@terry-xiaoyu terry-xiaoyu force-pushed the cannot_reset_metrics_for_fallback_actions branch from 9f5c0c5 to 6d52f90 Compare October 10, 2022 09:25
@terry-xiaoyu terry-xiaoyu merged commit 9a2300e into release-v43 Oct 10, 2022
@terry-xiaoyu terry-xiaoyu deleted the cannot_reset_metrics_for_fallback_actions branch October 10, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmstone zmstone Awaiting requested review from zmstone

1 more reviewer

@xiangfangyang-tech xiangfangyang-tech xiangfangyang-tech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@terry-xiaoyu @xiangfangyang-tech
0