8000 251016 upgrade eredis cluster to 0.8.10 by zmstone · Pull Request #16138 · emqx/emqx · GitHub
[go: up one dir, main page]
Skip to content

251016 upgrade eredis cluster to 0.8.10 #16138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 20, 2025
Merged

251016 upgrade eredis cluster to 0.8.10 #16138

merged 4 commits into from
Oct 20, 2025

Conversation

@zmstone
Copy link
Member
@zmstone zmstone commented Oct 17, 2025 •
edited by atlassian bot
Loading

Fixes EMQX-14836

Release version: 5.8.9 5.9.2 5.10.2

Summary

This fix makes sure that redis cluster topology is refreshed if PING command failed

See also: emqx/eredis_cluster#39

PR Checklist

  • For internal contributor: there is a jira ticket to track this change
  • The changes are covered with new or existing tests
  • Change log for changes visible by users has been added to changes/ee/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • Schema changes are backward compatible or intentionally breaking (describe the changes and the reasoning in the summary)

@zmstone zmstone requested review from a team and JimMoen as code owners October 17, 2025 20:20
@zmstone zmstone mentioned this pull request Oct 17, 2025
Closed
4 tasks
@zmstone zmstone force-pushed the 251016-upgrade-eredis_cluster-to-0.8.10 branch from 3d61621 to 3bf232b Compare October 17, 2025 20:52
@zmstone zmstone requested a review from lafirest as a code owner October 17, 2025 20:52
@zmstone zmstone force-pushed the 251016-upgrade-eredis_cluster-to-0.8.10 branch from 3bf232b to ac11198 Compare October 17, 2025 20:56
@zmstone zmstone force-pushed the 251016-upgrade-eredis_cluster-to-0.8.10 branch from ac11198 to ddbe995 Compare October 17, 2025 21:03
@codecov-commenter
Copy link
codecov-commenter commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.30%. Comparing base (4bc95de) to head (ddbe995).
⚠️ Report is 125 commits behind head on release-58.

Files with missing lines Patch % Lines
apps/emqx_redis/src/emqx_redis.erl 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           release-58   #16138   +/-   ##
===========================================
  Coverage       82.29%   82.30%           
===========================================
  Files            1020     1021    +1     
  Lines           71664    71749   +85     
===========================================
+ Hits            58978    59051   +73     
- Misses          12686    12698   +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zmstone zmstone merged commit e3d3da3 into emqx:release-58 Oct 20, 2025
351 of 352 checks passed
@zmstone zmstone deleted the 251016-upgrade-eredis_cluster-to-0.8.10 branch October 20, 2025 07:24
@emqxqa
Copy link
emqxqa commented Oct 28, 2025

TestExecution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@id id id approved these changes

@JimMoen JimMoen Awaiting requested review from JimMoen JimMoen is a code owner

@lafirest lafirest Awaiting requested review from lafirest lafirest is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zmstone @codecov-commenter @emqxqa @id
0