E52F fix(ds): Add configuration for RocksDB options by ieQu1 · Pull Request #15463 · emqx/emqx · GitHub
[go: up one dir, main page]
Skip to content

fix(ds): Add configuration for RocksDB options #15463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 2, 2025
Merged

fix(ds): Add configuration for RocksDB options #15463

merged 6 commits into from
Jul 2, 2025

Conversation

@ieQu1
Copy link
Member
@ieQu1 ieQu1 commented Jul 1, 2025 •
edited
Loading

Fixes EMQX-14457

Release version: 6.0.0

Summary

In an effort to reduce the memory usage by the internal structures of the RocksDB NIF, this commit adds options that allow user to configure

  1. Block cache size
  2. Memtable size
  3. Maximum number of open files

PR Checklist

  • For internal contributor: there is a jira ticket to track this change
  • The changes are covered with new or existing tests
  • Change log for changes visible by users has been added to changes/ee/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • Schema changes are backward compatible or intentionally breaking (describe the changes and the reasoning in the summary)

@ieQu1 ieQu1 force-pushed the dev/rocksdb-config branch 2 times, most recently from 6045312 to 6f552d7 Compare July 1, 2025 23:13
@ieQu1 ieQu1 force-pushed the dev/rocksdb-config branch from 6f552d7 to a17456a Compare July 2, 2025 12:06
@ieQu1 ieQu1 marked this pull request as ready for review July 2, 2025 12:16
@ieQu1 ieQu1 requested review from a team and keynslug as code owners July 2, 2025 12:16
ieQu1
ieQu1 commented Jul 2, 2025
View reviewed changes
apps/emqx_durable_storage/src/emqx_ds_lts.erl
info/2,
info/1,

insert_wildcard/2,
Copy link
Member Author
@ieQu1 ieQu1 Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unused for now.

@codecov-commenter
Copy link
codecov-commenter commented Jul 2, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 63.82979% with 17 lines in your changes missing coverage. Please review.

Project coverage is 81.77%. Comparing base (a97dd23) to head (7b70de9).
Report is 53 commits behind head on master.

Files with missing lines Patch % Lines
...emqx_durable_storage/src/emqx_ds_storage_layer.erl 11.11% 16 Missing ⚠️
apps/emqx/src/emqx_ds_schema.erl 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           master   #15463       +/-   ##
===========================================
+ Coverage    3.81%   81.77%   +77.96%     
===========================================
  Files        1118     1123        +5     
  Lines       80766    82025     +1259     
===========================================
+ Hits         3082    67080    +63998     
+ Misses      77684    14945    -62739

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ieQu1 ieQu1 merged commit 8a09758 into emqx:master Jul 2, 2025
306 of 308 checks passed
@emqxqa
Copy link
emqxqa commented Jul 28, 2025

TestExecution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keynslug keynslug keynslug approved these changes

@thalesmg thalesmg thalesmg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ieQu1 @codecov-commenter @emqxqa @keynslug @thalesmg
0