fix(mqtt connector): reconnect automatically when emqtt clients disconnect
#14550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…connect Fixes https://emqx.atlassian.net/browse/EMQX-13824 The original problem stems from: - https://github.com/emqx/emqtt/blob/5605d7c77026cec5aa110aa209f980085f851dd5/src/emqtt.erl#L2083-L2087 - https://github.com/emqx/emqtt/blob/5605d7c77026cec5aa110aa209f980085f851dd5/src/emqtt.erl#L2316-L2318 - https://github.com/emqx/ecpool/blob/a50071e8f944636f1f7f5354488dfb6570278db6/src/ecpool_worker_sup.erl#L36 Basically, ecpool workers are always transient, and emqtt always terminates "normally", so they are not restarted, since `ecpool`'s `auto_reconnect` option was not being used.
c559531 to
aac9d0a
Compare
3 tasks
zmstone
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://emqx.atlassian.net/browse/EMQX-13824
Release version: v/e5.8.5
Summary
The original problem stems from:
Basically, ecpool workers are always transient, and emqtt always terminates "normally", so they are not restarted, since
ecpool'sauto_reconnectoption was not being used.PR Checklist
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfiles