8000 fix(prometheus): do not crash on disabled listeners by keynslug · Pull Request #14544 · emqx/emqx · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@keynslug
Copy link
Contributor
@keynslug keynslug commented Jan 13, 2025

Fixes #14525.

Release version: v/e5.8.5

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

thalesmg
thalesmg previously approved these changes Jan 13, 2025
@keynslug keynslug marked this pull request as ready for review January 14, 2025 10:25
@keynslug keynslug requested review from a team and JimMoen as code owners January 14, 2025 10:25
@keynslug keynslug merged commit ecadece into emqx:release-58 Jan 14, 2025
197 checks passed
@keynslug keynslug deleted the fix/GH-14541/prom branch January 14, 2025 13:59
@emqxqa
Copy link
emqxqa commented Feb 5, 2025

TestExecution

@emqxqa
Copy link
emqxqa commented Feb 5, 2025

TestExecution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0