8000 fix(gw): return correct keepalive value by HJianBo · Pull Request #14501 · emqx/emqx · GitHub
[go: up one dir, main page]
Skip to content

fix(gw): return correct keepalive value #14501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 10, 2025
Merged

fix(gw): return correct keepalive value #14501

merged 2 commits into from
Jan 10, 2025

Conversation

@HJianBo
Copy link
Member
@HJianBo HJianBo commented Jan 8, 2025

Fixes https://emqx.atlassian.net/browse/EMQX-13520

Release version: v/e5.8.5

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@HJianBo HJianBo marked this pull request as ready for review January 9, 2025 01:08
@HJianBo HJianBo requested review from a team and lafirest as code owners January 9, 2025 01:08
@HJianBo HJianBo merged commit f8f09bb into emqx:release-58 Jan 10, 2025
197 checks passed
@HJianBo HJianBo deleted the fix-the-keepalive-return branch January 10, 2025 02:36
@emqxqa
Copy link
emqxqa commented Feb 5, 2025

TestExecution

@emqxqa
Copy link
emqxqa commented Feb 5, 2025

TestExecution

@BrewTestBot BrewTestBot mentioned this pull request Feb 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thalesmg thalesmg thalesmg approved these changes

@lafirest lafirest Awaiting requested review from lafirest lafirest is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HJianBo @emqxqa @thalesmg
0