8000 fix: mismatch the check_gc message by zhongwencool · Pull Request #14201 · emqx/emqx · GitHub
[go: up one dir, main page]
Skip to content

fix: mismatch the check_gc message #14201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Nov 9, 2024
Merged

fix: mismatch the check_gc message #14201

merged 25 commits into from
Nov 9, 2024

Conversation

@zhongwencool
Copy link
Contributor
@zhongwencool zhongwencool commented Nov 9, 2024 •
edited by zmstone
Loading

Fixes #14198

Do not display a check_gc error when the WebSocket connection encounters a rate limit.

Missed updating the WebSocket connection’s check_gc. Introduce from 6a78951
impact version: 5.8.0, 5.8.1, and 5.8.2

Release version: v/e5.8.3

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

thalesmg and others added 24 commits November 5, 2024 10:06
@thalesmg
fix(retainer): show $SYS topics when iterating over all topics
946b12b 
Fixes https://emqx.atlassian.net/browse/EMQX-13399
@savonarola
fix(client_api): correctly apply conn_state selector in search queries
09e1375
@id
chore: 5.8.2-beta.1
23a7d7a
@HJianBo
perf(audit): only truncate the http body
bb78a91
@HJianBo
chore: update changes
67eda65
@qzhuyan
build(el7): workaround for QUIC transport
73b81c7
@thalesmg
Merge pull request emqx#14150 from thalesmg/20241105-r58-retainer-api…
b1f6298 
…-total-count

fix(retainer): show `$SYS` topics when iterating over all topics
@thalesmg
fix(cluster link): restart connection if actor init fails
cb4d841 
Fixes https://emqx.atlassian.net/browse/EMQX-13350
@qzhuyan
Merge pull request emqx#14157 from qzhuyan/build/el7-quic-nolink-libc…
63ef62a 
…rypto

build(el7): workaround for QUIC transport
@thalesmg
test: fix test setup
2b21f44
@savonarola
Merge pull request emqx#14151 from savonarola/1105-client-v2-fix-status
c37352c 
fix(client_api): correctly apply conn_state selector in search queries
@lafirest
fix(iotdb): return error if set up a Thrift driver in batch mode
f9f2da8
@HJianBo
Merge pull request emqx#14167 from lafirest/fix/thrift_batch
621dbe9 
fix(iotdb): return error if set up a Thrift driver in batch mode
@HJianBo
Merge pull request emqx#14152 from HJianBo/only-truncate-http-body
ec1edad 
Audit: Only truncate http body
@thalesmg
Merge pull request emqx#14155 from thalesmg/20241105-r58-clink-actor-…
92b31d1 
…init

fix(cluster link): restart connection if actor init fails
@thalesmg
fix(retainer cli): list all topics
3f43388 
Fixes https://emqx.atlassian.net/browse/EMQX-13452
@thalesmg
Merge pull request emqx#14179 from thalesmg/20241107-r58-retainer-cli…
e04ef4c 
…-sys-topics

fix(retainer cli): list all topics
@savonarola
fix(dashboard): fix slow fetching of persistent session stats
b2dee27
@savonarola
Merge pull request emqx#14184 from emqx/1107-fix-bookkeeper-fetch-stats
b8485b2 
fix(dashboard): fix slow fetching of persistent session stats
@ieQu1
fix(sessds): Trigger stream renewal after encountering end of stream
8355dba
@id
Merge pull request emqx#14185 from ieQu1/dev/tmp-fix-renew-streams
a819bd6 
fix(sessds): Trigger stream renewal after encountering end of stream
@Kinplemelon
chore: bump dashboard version
37f1e2c
@id
Merge pull request emqx#14188 from emqx/bump-emqx-enterprise-dashboar…
385acbc 
…d-version-20241108-075655

bump emqx-enterprise dashboard version
@zhongwencool
fix: mismatch the check_gc message
4626235
@zhongwencool zhongwencool requested review from a team and lafirest as code owners November 9, 2024 03:33
@zmstone zmstone changed the base branch from release-58 to release-583 November 9, 2024 09:26
@zmstone zmstone requested a review from Rory-Z as a code owner November 9, 2024 09:26
@zmstone zmstone merged commit 9e4db0b into emqx:release-583 Nov 9, 2024
199 checks passed
@zhongwencool zhongwencool deleted the fix-check-gc-check branch November 9, 2024 10:03
@emqxqa
Copy link
emqxqa commented Nov 18, 2024

TestExecution

@BrewTestBot BrewTestBot mentioned this pull request Dec 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmstone zmstone zmstone approved these changes

@lafirest lafirest Awaiting requested review from lafirest

@Rory-Z Rory-Z Awaiting requested review from Rory-Z

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.
0