8000 fix(kafka producer): kick off recovery from disk for fixed topics, migrate old replayq directories by thalesmg · Pull Request #14015 · emqx/emqx · GitHub
[go: up one dir, main page]
Skip to content

fix(kafka producer): kick off recovery from disk for fixed topics, migrate old replayq directories #14015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 21, 2024
Merged

fix(kafka producer): kick off recovery from disk for fixed topics, migrate old replayq directories #14015

merged 6 commits into from
Oct 21, 2024

Conversation

@thalesmg
Copy link
Contributor
@thalesmg thalesmg commented Oct 17, 2024 •
edited
Loading

Fixes https://emqx.atlassian.net/browse/EMQX-13242
Fixes https://emqx.atlassian.net/browse/EMQX-13248

Release version: e5.8.2

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@thalesmg thalesmg force-pushed the 20241017-m-kafka-recover-disk-static branch 2 times, most recently from 8e7ec85 to 7ba9c0b Compare October 17, 2024 21:00
@thalesmg thalesmg force-pushed the 20241017-m-kafka-recover-disk-static branch from 7ba9c0b to 64b1661 Compare October 18, 2024 12:29
@thalesmg thalesmg changed the base branch from master to release-58 October 18, 2024 12:31
@thalesmg thalesmg force-pushed the 20241017-m-kafka-recover-disk-static branch from 64b1661 to 19c05d2 Compare October 18, 2024 13:28
@thalesmg thalesmg changed the title fix(kafka producer): kick off recovery from disk for fixed topics fix(kafka producer): kick off recovery from disk for fixed topics, migrate old replayq directories Oct 18, 2024
@thalesmg thalesmg force-pushed the 20241017-m-kafka-recover-disk-static branch 2 times, most recently from 85e4046 to 8bfc6ff Compare October 18, 2024 17:23
@thalesmg
fix(kafka producer): kick off recovery from disk for fixed topics
8b342d5 
Fixes https://emqx.atlassian.net/browse/EMQX-13242
@thalesmg
chore: disallow disk buffer when dynamic topics are used
ee192e5 
Fixes https://emqx.atlassian.net/browse/EMQX-13242

BREAKING CHANGE:

Kafka/Confluent/Azure Event Hub Producers with a dynamic topic (i.e., a topic that contains placeholders) no longer support disk buffering.  Only memory and hybrid modes are now supported.
@thalesmg
style: disable broken elvis check
bb63f84 
```
    - Atom [] on line -1 does not respect the format defined by the regular expression '"^([a-z][a-z0-9]*_?)([a-z0-9]*_?)*$"'.
```
@thalesmg
feat: migrate old replayq directories to new structure
25aa0ae 
Fixes https://emqx.atlassian.net/browse/EMQX-13248
@thalesmg thalesmg force-pushed the 20241017-m-kafka-recover-disk-static branch from 8bfc6ff to 25aa0ae Compare October 18, 2024 18:35
@thalesmg thalesmg marked this pull request as ready for review October 18, 2024 19:22
@thalesmg thalesmg requested a review from a team as a code owner October 18, 2024 19:22
zmstone
zmstone reviewed Oct 19, 2024
View reviewed changes
@thalesmg thalesmg requested a review from zmstone October 21, 2024 13:17
@thalesmg thalesmg merged commit f71886b into emqx:release-58 Oct 21, 2024
199 checks passed
@thalesmg thalesmg deleted the 20241017-m-kafka-recover-disk-static branch October 21, 2024 13:57
@emqxqa
Copy link
emqxqa commented Oct 22, 2024

TestExecution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmstone zmstone zmstone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thalesmg @emqxqa @zmstone
0