10BC0 feat: support bootstrap_file on authentication for build-in-database by zhongwencool · Pull Request #13336 · emqx/emqx · GitHub
[go: up one dir, main page]
Skip to content

feat: support bootstrap_file on authentication for build-in-database #13336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 28, 2024
Merged

feat: support bootstrap_file on authentication for build-in-database #13336

merged 7 commits into from
Jun 28, 2024

Conversation

@zhongwencool
Copy link
Contributor
@zhongwencool zhongwencool commented Jun 26, 2024 •
edited by id
Loading

Fixes https://emqx.atlassian.net/browse/EMQX-12593

close #8714, #9148
This feature needs to be used before enabling built_in_database authn,
so it makes sense to add configuration items to it.

Use the same template for initialization as for importing users:

Import data only on build-in-dabase create.

Support for JSON, CSV files.

authentication = [
  {
    backend = built_in_database
    mechanism = password_based
    password_hash_algorithm {name = sha256, salt_position = suffix}
    user_id_type = username
    
    # new items
    bootstrap_file = "/opt/init_user.json"
    bootstrap_type = hash | plain
  }
]

Release version: v/e5.7.2

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@zhongwencool zhongwencool marked this pull request as ready for review June 26, 2024 01:08
@zhongwencool zhongwencool requested a review from a team as a code owner June 26, 2024 01:08
@zhongwencool zhongwencool force-pushed the authn-boostrap-file branch 3 times, most recently from 4ad781c to b34b1a1 Compare June 26, 2024 03:41
@zhongwencool zhongwencool changed the title feat: support bootstrap_file on build-in-db authn feat: support bootstrap_file on authentication for build-in-database Jun 26, 2024
zmstone
zmstone reviewed Jun 26, 2024
View reviewed changes
zmstone
zmstone reviewed Jun 26, 2024
View reviewed changes
zmstone
zmstone reviewed Jun 26, 2024
View reviewed changes
zmstone
zmstone reviewed Jun 26, 2024
View reviewed changes
@zhongwencool zhongwencool force-pushed the authn-boostrap-file branch from f4b566d to 263f995 Compare June 27, 2024 03:35
@zhongwencool zhongwencool force-pushed the authn-boostrap-file branch from 263f995 to cbaa0b0 Compare June 27, 2024 07:22
zmstone
zmstone reviewed Jun 27, 2024
View reviewed changes
zmstone
zmstone reviewed Jun 27, 2024
View reviewed changes
@zmstone zmstone changed the base branch from release-572 to release-57 June 27, 2024 10:47
zhongwencool
zhongwencool commented Jun 27, 2024
View reviewed changes
@zhongwencool @zmstone
chore: apply suggestions from code review
d908613 
Co-authored-by: zmstone <zmstone@gmail.com>
zmstone
zmstone reviewed Jun 27, 2024
View reviewed changes
@HJianBo HJianBo merged commit b39557f into emqx:release-57 Jun 28, 2024
@zhongwencool zhongwencool deleted the authn-boostrap-file branch June 28, 2024 02:22
@zhongwencool zhongwencool mentioned this pull request Jul 2, 2024
Merged
9 tasks
@emqxqa
Copy link
emqxqa commented Jul 3, 2024

TestExecution

@BrewTestBot BrewTestBot mentioned this pull request Aug 7, 2024
Merged
@id id mentioned this pull request Aug 15, 2024
Closed
@rouke-broersma rouke-broersma mentioned this pull request Aug 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmstone zmstone zmstone approved these changes

@HJianBo HJianBo HJianBo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhongwencool @emqxqa @zmstone @HJianBo
0