8000 fix(kafka and derivatives): add `alias` config to avoid clashes with same topic by thalesmg · Pull Request #13327 · emqx/emqx · GitHub
[go: up one dir, main page]
Skip to content

fix(kafka and derivatives): add alias config to avoid clashes with same topic #13327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 28, 2024
Merged

fix(kafka and derivatives): add alias config to avoid clashes with same topic #13327

merged 7 commits into from
Jun 28, 2024

Conversation

@thalesmg
Copy link
Contributor
@thalesmg thalesmg commented Jun 24, 2024 •
edited
Loading

Fixes https://emqx.atlassian.net/browse/EMQX-12592
Fixes https://emqx.atlassian.net/browse/EMQX-12585

Release version: e5.7.2

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@thalesmg thalesmg force-pushed the fix-kprodu-delete-wolff-r57-20240624 branch from f7e7558 to e1093eb Compare June 24, 2024 17:51
@thalesmg
Copy link
Contributor Author
thalesmg commented Jun 24, 2024 •
edited
Loading

Depends on kafka4beam/wolff#68 being tagged with 2.0.0
🏁

@thalesmg thalesmg force-pushed the fix-kprodu-delete-wolff-r57-20240624 branch 3 times, most recently from 58b1211 to cd1d40d Compare June 24, 2024 20:31
@thalesmg thalesmg changed the title fix(kafka and derivatives): add alias config to avoid clashes with same topic [wip] fix(kafka and derivatives): add alias config to avoid clashes with same topic Jun 24, 2024
@thalesmg thalesmg force-pushed the fix-kprodu-delete-wolff-r57-20240624 branch 3 times, most recently from 86235ca to 854b4aa Compare June 25, 2024 12:35
@thalesmg thalesmg changed the base branch from release-57 to release-572 June 25, 2024 12:35
@thalesmg thalesmg force-pushed the fix-kprodu-delete-wolff-r57-20240624 branch from 854b4aa to ee4d5aa Compare June 25, 2024 13:50
@thalesmg thalesmg changed the title [wip] fix(kafka and derivatives): add alias config to avoid clashes with same topic fix(kafka and derivatives): add alias config to avoid clashes with same topic Jun 25, 2024
@thalesmg thalesmg force-pushed the fix-kprodu-delete-wolff-r57-20240624 branch 3 times, most recently from 051ff7b to 955b3d8 Compare June 26, 2024 16:46
@thalesmg thalesmg marked this pull request as ready for review June 26, 2024 17:53
@thalesmg thalesmg requested review from a team and kjellwinblad as code owners June 26, 2024 17:53
@thalesmg thalesmg requested a review from zmstone June 26, 2024 17:59
@thalesmg thalesmg changed the base branch from release-572 to release-57 June 27, 2024 12:19
@thalesmg thalesmg force-pushed the fix-kprodu-delete-wolff-r57-20240624 branch from 955b3d8 to 4c3c86e Compare June 27, 2024 12:20
zmstone
zmstone reviewed Jun 28, 2024
View reviewed changes
thalesmg and others added 2 commits June 28, 2024 12:06
@thalesmg
chore: add count to thrown error
067beec
@thalesmg @zmstone
docs: improve descriptions
fd49f66 
Co-authored-by: zmstone <zmstone@gmail.com>
@thalesmg thalesmg requested a review from zmstone June 28, 2024 17:23
@thalesmg thalesmg merged commit 9215b37 into emqx:release-57 Jun 28, 2024
@thalesmg thalesmg deleted the fix-kprodu-delete-wolff-r57-20240624 branch June 28, 2024 18:22
@emqxqa
Copy link
emqxqa commented Jul 3, 2024

TestExecution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmstone zmstone zmstone approved these changes

@kjellwinblad kjellwinblad Awaiting requested review from kjellwinblad kjellwinblad is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thalesmg @emqxqa @zmstone
0