10BC0 fix: check willretain and willqos when WillFlag set to `true` by JimMoen · Pull Request #13222 · emqx/emqx · GitHub
[go: up one dir, main page]
Skip to content

fix: check willretain and willqos when WillFlag set to true #13222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 20, 2024
Merged

fix: check willretain and willqos when WillFlag set to true #13222

merged 2 commits into from
Jun 20, 2024

Conversation

@JimMoen
Copy link
Member
@JimMoen JimMoen commented Jun 10, 2024 •
edited by HJianBo
Loading

Fixes EMQX-12503

Release version: v/e5.7.2

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • [ ] Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • [ ] Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • [ ] Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • [ ] If changed package build workflow, pass this action (manual trigger)
  • [ ] Change log has been added to changes/ dir for user-facing artifacts update

@JimMoen JimMoen requested review from a team and lafirest as code owners June 10, 2024 19:51
qzhuyan
qzhuyan previously approved these changes Jun 11, 2024
View reviewed changes
qzhuyan
qzhuyan reviewed Jun 11, 2024
View reviewed changes
@JimMoen JimMoen marked this pull request as draft June 11, 2024 09:02
@JimMoen
Copy link
Member Author
JimMoen commented Jun 11, 2024

fix in v/e5.7.2
merge after v/e5.7.1 released

@JimMoen JimMoen force-pushed the fix-will-qos-retain-flag-check branch from 460a510 to 702dfab Compare June 20, 2024 01:46
@JimMoen JimMoen changed the base branch from release-57 to release-572 June 20, 2024 01:47
@JimMoen JimMoen dismissed qzhuyan’s stale review June 20, 2024 01:47

The base branch was changed.

@JimMoen JimMoen force-pushed the fix-will-qos-retain-flag-check branch from 702dfab to 675abd7 Compare June 20, 2024 02:32
@JimMoen JimMoen marked this pull request as ready for review June 20, 2024 02:33
@JimMoen JimMoen merged commit acc8bf3 into emqx:release-572 Jun 20, 2024
@JimMoen JimMoen deleted the fix-will-qos-retain-flag-check branch June 21, 2024 01:52
@emqxqa
Copy link
emqxqa commented Jul 3, 2024

TestExecution

@BrewTestBot BrewTestBot mentioned this pull request Aug 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qzhuyan qzhuyan qzhuyan approved these changes

@lafirest lafirest Awaiting requested review from lafirest

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JimMoen @emqxqa @qzhuyan
0