8000 fix(authz_mnesia): add a soft limit in the API for the length of ACL rules by lafirest · Pull Request #13196 · emqx/emqx · GitHub
[go: up one dir, main page]
Skip to content

fix(authz_mnesia): add a soft limit in the API for the length of ACL rules #13196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 17, 2024
Merged

fix(authz_mnesia): add a soft limit in the API for the length of ACL rules #13196

merged 3 commits into from
Jun 17, 2024

Conversation

@lafirest
Copy link
Member
@lafirest lafirest commented Jun 6, 2024 •
edited
Loading

Fixes EMQX-12465
Release version: v/e5.?

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@lafirest lafirest marked this pull request as ready for review June 6, 2024 10:11
@lafirest lafirest requested a review from a team as a code owner June 6, 2024 10:11
@lafirest lafirest marked this pull request as draft June 6, 2024 10:11
@lafirest lafirest marked this pull request as ready for review June 6, 2024 23:02
zmstone
zmstone reviewed Jun 8, 2024
View reviewed changes
@lafirest lafirest force-pushed the fix/rules_len branch 2 times, most recently from 0642334 to dd890c9 Compare June 14, 2024 01:45
HJianBo
HJianBo approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member
@HJianBo HJianBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lafirest lafirest merged commit 98a5499 into emqx:master Jun 17, 2024
@lafirest lafirest deleted the fix/rules_len branch June 17, 2024 07:48
@emqxqa
Copy link
emqxqa commented Aug 9, 2024

TestExecution

@BrewTestBot BrewTestBot mentioned this pull request Aug 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmstone zmstone zmstone left review comments

@HJianBo HJianBo HJianBo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lafirest @emqxqa @zmstone @HJianBo
0