E52A fix: non-utf8 clientid connect event case crash if strict_mod=false by zhongwencool · Pull Request #12944 · emqx/emqx · GitHub
[go: up one dir, main page]
Skip to content

fix: non-utf8 clientid connect event case crash if strict_mod=false #12944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 9, 2024
Merged

fix: non-utf8 clientid connect event case crash if strict_mod=false #12944

merged 3 commits into from
May 9, 2024

Conversation

@zhongwencool
Copy link
Contributor
@zhongwencool zhongwencool commented Apr 29, 2024 •
edited by zmstone
Loading

Fixes

Release version: v/e5.7.1

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@zhongwencool zhongwencool requested review from a team and lafirest as code owners April 29, 2024 04:07
@zhongwencool zhongwencool force-pushed the mqtt-utf8-strict-mode branch from 20a908a to ef9a63a Compare April 29, 2024 06:43
JimMoen
JimMoen reviewed May 7, 2024
View reviewed changes
@zhongwencool zhongwencool merged commit 107d00a into emqx:master May 9, 2024
@zhongwencool zhongwencool deleted the mqtt-utf8-strict-mode branch May 9, 2024 01:16
@emqxqa
Copy link
emqxqa commented Jun 14, 2024

TestExecution

@BrewTestBot BrewTestBot mentioned this pull request Aug 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JimMoen JimMoen JimMoen left review comments

@HJianBo HJianBo HJianBo approved these changes

@lafirest lafirest Awaiting requested review from lafirest

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhongwencool @emqxqa @HJianBo @JimMoen
0