8000 feat(emqx_trace): add JSON trace log entry formatter by kjellwinblad · Pull Request #12863 · emqx/emqx · GitHub
[go: up one dir, main page]
Skip to content

feat(emqx_trace): add JSON trace log entry formatter #12863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Apr 22, 2024
Merged

feat(emqx_trace): add JSON trace log entry formatter #12863

merged 18 commits into from
Apr 22, 2024

Conversation

@kjellwinblad
Copy link
Contributor
@kjellwinblad kjellwinblad commented Apr 11, 2024 •
edited
Loading

This PR makes it possible to select the JSON trace log entry formatter when crating a trace pattern. This will make it easier for the dashboard and automatic tests to parse the log entries.

Fixes: EMQX-12025 (partly)

Release version: v/e5.?

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • [] Added property-based tests for code which performs user input validation
  • [] Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • [] Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

@kjellwinblad kjellwinblad marked this pull request as ready for review April 14, 2024 09:20
@kjellwinblad kjellwinblad requested review from a team and lafirest as code owners April 14, 2024 09:20
@kjellwinblad kjellwinblad requested a review from zmstone April 16, 2024 09:25
zmstone
zmstone reviewed Apr 16, 2024
View reviewed changes
zmstone
zmstone reviewed Apr 16, 2024
View reviewed changes
@kjellwinblad kjellwinblad force-pushed the kjell/new_trace_log_formatter/EMQX-12025 branch from 1188df9 to 10957e7 Compare April 18, 2024 08:39
@kjellwinblad kjellwinblad force-pushed the kjell/new_trace_log_formatter/EMQX-12025 branch from 53c142c to 3232ab5 Compare April 18, 2024 09:27
@kjellwinblad
fix(json trace format): format client_ids and rule_ids as lists
aa388ad
@kjellwinblad
fix(rule tracing): unset trace meta data in try-after-end
3232ab5 
We wrap the reset of the process trace meta data in the after clause of
a try-after-end expression to be sure we never get any lingering
incorrect meta data.
@kjellwinblad kjellwinblad force-pushed the kjell/new_trace_log_formatter/EMQX-12025 branch from 67fbd9e to f5b0439 Compare April 18, 2024 12:25
@kjellwinblad
fix: clean up trace messages to make it easier to interpret
8f1486f 
This commit removes some redundant trace messages and renames some to
make it easier to interpret what is happening for the user.
@kjellwinblad
fix(emqx_rule_engine_api_rule_apply_SUITE): flaky test case
f5b0439
@kjellwinblad
Copy link
Contributor Author
kjellwinblad commented Apr 18, 2024 •
edited
Loading

I used this PR to introduce some improvements to the rule tracing:

zmstone
zmstone reviewed Apr 19, 2024
View reviewed changes
@kjellwinblad kjellwinblad requested a review from zmstone April 19, 2024 07:50
zmstone
zmstone previously approved these changes Apr 19, 2024
View reviewed changes
@kjellwinblad
fix(emqx_trace_SUITE:t_base_create_delete): broken test case
9e46c18
@kjellwinblad
fix(tracing): remove internal extra field from the trace config
2890bc2 
This commit removes the internal extra field from the trace config
structure exposed to the user via the HTTP API.
@kjellwinblad kjellwinblad requested a review from zmstone April 19, 2024 15:38
@kjellwinblad kjellwinblad merged commit 6e99f01 into emqx:master Apr 22, 2024
@emqxqa
Copy link
emqxqa commented May 8, 2024 •
edited
Loading

Test Execution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmstone zmstone zmstone approved these changes

@lafirest lafirest Awaiting requested review from lafirest

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kjellwinblad @emqxqa @zmstone
0