8000 fix(prom): api crash when tls cert file non existed by JimMoen · Pull Request #12606 · emqx/emqx · GitHub
[go: up one dir, main page]
Skip to content

fix(prom): api crash when tls cert file non existed #12606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 28, 2024
Merged

fix(prom): api crash when tls cert file non existed #12606

merged 5 commits into from
Feb 28, 2024

Conversation

@JimMoen
Copy link
Member
@JimMoen JimMoen commented Feb 28, 2024 •
edited
Loading

Fixes EMQX-11914
Fixes #12603

The prom data of emqx_cert_expiry_at will be 0 for non-existed cert.

Release version: v/e5.5.1

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@JimMoen JimMoen mentioned this pull request Feb 28, 2024
Closed
zmstone
zmstone reviewed Feb 28, 2024
View reviewed changes
zmstone
zmstone reviewed Feb 28, 2024
View reviewed changes
@JimMoen JimMoen marked this pull request as ready for review February 28, 2024 06:52
@JimMoen JimMoen requested a review from a team as a code owner February 28, 2024 06:52
@JimMoen JimMoen force-pushed the EMQX-11914/fix-prom-api-crash branch from 761a661 to 5f12504 Compare February 28, 2024 06:53
zmstone
zmstone reviewed Feb 28, 2024
View reviewed changes
zmstone
zmstone reviewed Feb 28, 2024
View reviewed changes
zmstone
zmstone reviewed Feb 28, 2024
View reviewed changes
@JimMoen JimMoen force-pushed the EMQX-11914/fix-prom-api-crash branch from ee4e8bb to 6fd04e3 Compare February 28, 2024 07:40
@JimMoen JimMoen mentioned this pull request Feb 28, 2024
Merged
@JimMoen JimMoen merged commit eaa0bfd into emqx:release-55 Feb 28, 2024
@JimMoen JimMoen deleted the EMQX-11914/fix-prom-api-crash branch February 28, 2024 09:08
@BrewTestBot BrewTestBot mentioned this pull request Mar 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmstone zmstone zmstone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JimMoen @zmstone
0