8000 fix(ldap): fix that logs of eldap will never be logged by lafirest · Pull Request #12601 · emqx/emqx · GitHub
[go: up one dir, main page]
Skip to content

fix(ldap): fix that logs of eldap will never be logged #12601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 27, 2024
Merged

fix(ldap): fix that logs of eldap will never be logged #12601

merged 3 commits into from
Feb 27, 2024

Conversation

@lafirest
Copy link
Member
@lafirest lafirest commented Feb 27, 2024 •
edited by zmstone
Loading

cherry-pick from master

Release version: v/e5.5.1

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@lafirest lafirest marked this pull request as ready for review February 27, 2024 10:57
@lafirest lafirest requested a review from a team as a code owner February 27, 2024 10:57
zmstone
zmstone previously approved these changes Feb 27, 2024
View reviewed changes
@zmstone
Copy link
Member
zmstone commented Feb 27, 2024

missing changelog ?

@lafirest lafirest requested a review from zmstone February 27, 2024 13:39
@lafirest lafirest merged commit 02de92a into emqx:release-55 Feb 27, 2024
@lafirest lafirest deleted the fix/eldap_log branch February 27, 2024 13:50
@BrewTestBot BrewTestBot mentioned this pull request Mar 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmstone zmstone zmstone approved these changes

@thalesmg thalesmg thalesmg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lafirest @zmstone @thalesmg
0