E521 feat(import_users): support user's password in plain text by HJianBo · Pull Request #12396 · emqx/emqx · GitHub
[go: up one dir, main page]
Skip to content

feat(import_users): support user's password in plain text #12396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 30, 2024
Merged

feat(import_users): support user's password in plain text #12396

merged 11 commits into from
Jan 30, 2024

Conversation

@HJianBo
Copy link
Member
@HJianBo HJianBo commented Jan 25, 2024 •
edited
Loading

Fixes https://emqx.atlassian.net/browse/EMQX-11768

Release version: v/e5.5.0

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@HJianBo HJianBo marked this pull request as ready for review January 26, 2024 05:38
@HJianBo HJianBo requested review from a team, JimMoen, lafirest and savonarola as code owners January 26, 2024 05:38
zmstone
zmstone reviewed Jan 26, 2024
View reviewed changes
ieQu1
ieQu1 previously approved these changes Jan 29, 2024
View reviewed changes
zmstone
zmstone reviewed Jan 29, 2024
View reviewed changes
@HJianBo @ieQu1
chore: apply suggestions from code review
ded1b4d 
Co-authored-by: ieQu1 <99872536+ieQu1@users.noreply.github.com>
@HJianBo HJianBo merged commit 4688b36 into emqx:release-55 Jan 30, 2024
@HJianBo HJianBo deleted the import_user_2 branch January 30, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmstone zmstone zmstone approved these changes

@ieQu1 ieQu1 ieQu1 left review comments

@lafirest lafirest Awaiting requested review from lafirest lafirest is a code owner

@JimMoen JimMoen Awaiting requested review from JimMoen JimMoen is a code owner

@savonarola savonarola Awaiting requested review from savonarola savonarola is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HJianBo @zmstone @ieQu1
0