feat: support regular raw acl rule in jwt acl claim #12189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b87fdb8 to
cdc3e5f
Compare
dbf8029 to
93651e8
Compare
93651e8 to
2be898c
Compare
savonarola
reviewed
Dec 19, 2023
| catch | ||
| throw:{bad_acl_rule, Reason} -> | ||
| %% it's a invalid token, so ok to log | ||
| ?TRACE_AUTHN_PROVIDER("bad_acl_rule", Reason#{jwt => JWT}), |
8000
Contributor
There was a problem hiding this comment.
Previously, the validation was lazy, that is, invalid rules were handled on authz stage. This is kept for v1 rules;
For v2 we now break connection, don't we consider this to be a breaking change?
Member
Author
There was a problem hiding this comment.
A invalid token will cause any pub/sub action to fail, maybe it's better to close connection early.
It's a new format, so maybe it's not entirely a breaking change since all the v1 clients will not notice any change.
savonarola
reviewed
Dec 19, 2023
| JWT = generate_jws(Payload), | ||
| test_topic_rules(JWT). | ||
|
|
||
| t_topic_rules_v2(_Config) -> |
Contributor
There was a problem hiding this comment.
nit: maybe add qos/retain to v2 examples
savonarola
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12187 and EMQX-11372
Release version:
v/e5.5.0Summary
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update