8000 Fix shared sub api internal error by JimMoen · Pull Request #12141 · emqx/emqx · GitHub
[go: up one dir, main page]
Skip to content

Fix shared sub api internal error #12141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 11, 2023
Merged

Fix shared sub api internal error #12141

merged 2 commits into from
Dec 11, 2023

Conversation

@JimMoen
Copy link
Member
@JimMoen JimMoen commented Dec 11, 2023

Fixes EMQX-11519

Release version: v/e5.4.0

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@JimMoen JimMoen requested review from a team, lafirest and sstrigler as code owners December 11, 2023 07:14
@JimMoen JimMoen force-pushed the fix-shared-sub-api-internal-error branch from 6645868 to 8c25371 Compare December 11, 2023 07:37
@JimMoen JimMoen merged commit 6552e05 into emqx:release-54 Dec 11, 2023
@JimMoen JimMoen deleted the fix-shared-sub-api-internal-error branch December 11, 2023 13:43
zmstone added a commit to zmstone/emqx that referenced this pull request Feb 10, 2025
@zmstone
docs: fix emqx#12141 change log
a9110ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmstone zmstone zmstone approved these changes

@ieQu1 ieQu1 ieQu1 approved these changes

@lafirest lafirest Awaiting requested review from lafirest lafirest is a code owner

@sstrigler sstrigler Awaiting requested review from sstrigler

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JimMoen @zmstone @ieQu1
0