10000 Fix COAP sub opts by SergeTupchiy · Pull Request #12048 · emqx/emqx · GitHub
[go: up one dir, main page]
Skip to content

Fix COAP sub opts #12048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 5, 2023
Merged

Fix COAP sub opts #12048

merged 2 commits into from
Dec 5, 2023

Conversation

@SergeTupchiy
Copy link
Contributor
@SergeTupchiy SergeTupchiy commented Nov 28, 2023 •
edited by zmstone
Loading

Fixes #12031

Release version: v/e5.4.0

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@SergeTupchiy SergeTupchiy requested a review from a team as a code owner November 28, 2023 17:53
@SergeTupchiy
fix(emqx_gateway_coap): take subscribe options from uri_query
3530ed6 
Closes emqx#12031
@SergeTupchiy
test: use emqx_cth_suite in emqx_coap_api_SUITE
b0d4ba1 
`emqx_coap_api_SUITE` was failing with `emqx_authn_schema_not_injected`
(missing authn schema mods in persistent_term) if it was run standalone.
@SergeTupchiy SergeTupchiy changed the title Fix coap sub opts Fix COAP sub opts Nov 28, 2023
@SergeTupchiy SergeTupchiy merged commit 7b9d12f into emqx:master Dec 5, 2023
This was referenced Dec 22, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmstone zmstone zmstone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Topic Subscribe Gateway COAP does not accept QOS parameters

2 participants

@SergeTupchiy @zmstone
0