Do not trace authn http request bodies #11750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b616836 to
11defc5
Compare
savonarola
commented
Oct 11, 2023
Contributor
Author
There was a problem hiding this comment.
Seems that we already decided not to log request bodies, so I just chose to do that more consistently.
Also the redacted authn request (with body) is already logged in the authn provider itself.
Contributor
Author
|
Also, a user may choose to send the password in the URL part. However, this is completely insecure in many levels, so I don't think we should try to redact the URL all. Maybe we should just forbid password interpolation in the URL part instead. |
Member
|
we probably need to trace the parameters used to build the request body (before encoded to JSON). |
Contributor
Author
|
@zmstone we trace full and secured request inside the provider https://github.com/emqx/emqx/blob/master/apps/emqx_auth_http/src/emqx_authn_http.erl#L73 |
zmstone
reviewed
Oct 12, 2023
11defc5 to
68f31a9
Compare
thalesmg
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-11130
Summary
🤖 Generated by Copilot at c237ddf
This pull request enhances the security, logging, and tracing of HTTP authentication and bridge requests, adds a new GitHub workflow for Scorecard analysis, fixes some bugs and flaky tests, and updates the version number of the emqx_bridge_http application. It modifies the files
emqx_authn_http.erl,emqx_bridge_http_connector.erl,emqx_bridge_http_SUITE.erl,scorecard.yaml,emqx_bridge_http_connector.hrl,emqx_bridge_http.app.src, andemqx_bridge_kafka_impl_consumer_SUITE.erl.PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix)-<PR-id>.en.mdfiles