fix(kafka_producer): send messages to wolff producer to buffer even when connector is in connecting state (sync query mode)
#11722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen connector is in `connecting` state Fixes https://emqx.atlassian.net/browse/EMQX-11085 Messages would not be sent to wolff if the connection was down, so they were effectively lost.
ea170df to
34186fc
Compare
Collaborator
Pull Request Test Coverage Report for Build 6433089882
💛 - Coveralls |
qzhuyan
approved these changes
Oct 6, 2023
connecting stateconnecting state (sync query mode)
zmstone
reviewed
Oct 7, 2023
| end. | ||
|
|
||
| do_call_query(QM, Id, Index, Ref, Query, #{is_buffer_supported := true} = QueryOpts, Resource) -> | ||
| do_call_query(QM, Id, Index, Ref, Query, QueryOpts, #{query_mode := ResQM} = Resource) when |
Member
There was a problem hiding this comment.
do the authn authz resources end up calling this path?
Contributor
Author
There was a problem hiding this comment.
Yes, they end up calling this function.
Contributor
Author
There was a problem hiding this comment.
Here I introduce a new query mode type: #11724
Perhaps it would be more appropriate to restrict this behavior to that more specific type.
Contributor
Author
There was a problem hiding this comment.
But I think we would also need to introduce a new query mode for the async version of a buffered connector, to have the correct semantics as well. 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://emqx.atlassian.net/browse/EMQX-11085
Messages would not be sent to wolff if the connection was down, so they were effectively lost.
Summary
🤖 Generated by Copilot at ea170df
Added a new module
emqx_bridge_kafka_impl_producerto implement the Kafka bridge producer logic using theemqx_resourcebehaviour. Improved the query handling and resource information in theemqx_resource_buffer_workermodule. Bumped the version of theemqx_resourceapplication and renamed a variable for clarity.PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update