feat(authn): integrate the LDAP authentication #11386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0a03370 to
f3df80e
Compare
f3df80e to
b4a21b6
Compare
thalesmg
reviewed
Aug 3, 2023
savonarola
reviewed
Aug 3, 2023
|
|
||
| -export([providers/0, resource_provider/0]). | ||
|
|
||
| -if(?EMQX_RELEASE_EDITION == ee). |
Contributor
There was a problem hiding this comment.
Nit: do we need compile-time condition? Maybe emqx_release:edition() is enough?
savonarola
reviewed
Aug 3, 2023
| without_password(Credential) -> | ||
| without_password(Credential, [password, <<"password">>]). | ||
|
|
||
| to_bool(<<"true">>) -> |
savonarola
approved these changes
Aug 3, 2023
paulozulato
reviewed
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-10697
Summary
🤖 Generated by Copilot at ae3f0f6
This pull request adds LDAP authentication support to the enterprise edition of emqx. It refactors the emqx_ldap module to improve the configuration validation and parsing, and adds a new emqx_ldap_authn module that implements the emqx_authentication behaviour for LDAP. It also updates the test suites and the internationalization files for the LDAP modules, and removes some unused files and code.
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update