8000 feat: ensure data backends don't leak sensitive data by lafirest · Pull Request #11207 · emqx/emqx · GitHub
[go: up one dir, main page]
Skip to content

feat: ensure data backends don't leak sensitive data #11207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 7, 2023
Merged

feat: ensure data backends don't leak sensitive data #11207

merged 3 commits into from
Jul 7, 2023

Conversation

@lafirest
Copy link
Member
@lafirest lafirest commented Jul 6, 2023 •
edited by ghost
Loading

Fixes EMQX-10479

Summary

🤖 Generated by Copilot at f001393

This pull request updates the dependency versions of several database clients to fix bugs, improve performance, and support new features. It also encrypts the password option for the mongodb worker using emqx_secret:wrap/1.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@lafirest lafirest marked this pull request as ready for review July 6, 2023 09:14
@lafirest lafirest requested a review from a team as a code owner July 6, 2023 09:14
@lafirest lafirest force-pushed the feat/keep_obfuscated branch 2 times, most recently from 663d9a7 to 6701966 Compare July 7, 2023 03:09
@lafirest lafirest force-pushed the feat/keep_obfuscated branch from 6701966 to a1d2b2c Compare July 7, 2023 03:18
@lafirest lafirest requested a review from JimMoen as a code owner July 7, 2023 03:18
@HJianBo HJianBo merged commit ab809c8 into emqx:master Jul 7, 2023
@coveralls
Copy link
Collaborator
coveralls commented Jul 7, 2023

Pull Request Test Coverage Report for Build 5482388878

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 38 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.03%) to 82.014%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/emqx_mongodb/src/emqx_mongodb.erl 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
apps/emqx_bridge_sqlserver/src/emqx_bridge_sqlserver_connector.erl 1 80.56%
apps/emqx_gateway/src/emqx_gateway_schema.erl 1 94.44%
apps/emqx/src/emqx_broker.erl 1 88.33%
apps/emqx/src/emqx_limiter/src/emqx_limiter_schema.erl 1 81.48%
apps/emqx/src/emqx_router_helper.erl 1 87.04%
apps/emqx/src/emqx_session.erl 1 87.65%
apps/emqx/src/emqx_banned.erl 3 89.55%
apps/emqx/src/emqx_channel.erl 3 87.41%
apps/emqx_oracle/src/emqx_oracle.erl 4 80.0%
apps/emqx_resource/src/emqx_resource_buffer_worker.erl 4 93.26%
Totals Coverage Status
Change from base Build 5481866954: -0.03%
Covered Lines: 30793
Relevant Lines: 37546
💛 - Coveralls

@lafirest lafirest deleted the feat/keep_obfuscated branch July 7, 2023 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HJianBo HJianBo HJianBo approved these changes

@JimMoen JimMoen Awaiting requested review from JimMoen JimMoen is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lafirest @coveralls @HJianBo
0