8000 fix: bad cert file path in dashboard https listener by zhongwencool · Pull Request #10761 · emqx/emqx · GitHub
[go: up one dir, main page]
Skip to content

fix: bad cert file path in dashboard https listener #10761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2023
Merged

fix: bad cert file path in dashboard https listener #10761

merged 2 commits into from
May 22, 2023

Conversation

@zhongwencool
Copy link
Contributor
@zhongwencool zhongwencool commented May 20, 2023 •
edited
Loading

Fixes EMQX-9952

Summary

🤖 Generated by Copilot at e5f84d1

This pull request enhances the dashboard HTTPS feature by improving the SSL configuration and validation, the error logging, the code readability, and the test coverage. It also fixes a minor issue with the dashboard test suite macro. It affects the files emqx_dashboard.erl, emqx_schema.erl, emqx_dashboard_https_SUITE.erl, emqx_dashboard_SUITE.erl, and emqx_tls_lib.erl.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@zhongwencool zhongwencool force-pushed the dashboard-https-listener branch from e5f84d1 to cd75362 Compare May 20, 2023 23:43
@zhongwencool zhongwencool marked this pull request as ready for review May 22, 2023 01:25
@zhongwencool zhongwencool requested review from a team, JimMoen and lafirest as code owners May 22, 2023 01:25
@zhongwencool zhongwencool merged commit 2ad8c41 into emqx:release-50 May 22, 2023
@zhongwencool zhongwencool deleted the dashboard-https-listener branch May 22, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6A12

Reviewers

@HJianBo HJianBo HJianBo approved these changes

@JimMoen JimMoen Awaiting requested review from JimMoen JimMoen is a code owner

@lafirest lafirest Awaiting requested review from lafirest lafirest is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zhongwencool @HJianBo
0